Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix clone with relative restart paths #516

Conversation

jo-basevi
Copy link
Collaborator

Added a fix for payu clone -r to resolve relative restart paths - with respect to the directory where payu clone is run from. I've changed it to call the helper method that checks restart path exists and resolves to an absolute path, before changing directory to the cloned repository which runs the checkout step.

Closes #514

@pep8speaks
Copy link

pep8speaks commented Sep 18, 2024

Hello @jo-basevi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found:

There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻

Comment last updated at 2024-09-25 23:21:02 UTC

@coveralls
Copy link

coveralls commented Sep 18, 2024

Coverage Status

coverage: 58.488% (+0.2%) from 58.285%
when pulling 2c48e3c on ACCESS-NRI:514-fix-payu-clone-relative-restart-paths
into f4af1ff on payu-org:master.

@jo-basevi jo-basevi force-pushed the 514-fix-payu-clone-relative-restart-paths branch from 7ac464e to 6b86c14 Compare September 18, 2024 06:59
@jo-basevi jo-basevi self-assigned this Sep 18, 2024
@jo-basevi jo-basevi marked this pull request as ready for review September 18, 2024 07:02
aidanheerdegen
aidanheerdegen previously approved these changes Sep 24, 2024
Copy link
Collaborator

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one clarifying question.

payu/branch.py Show resolved Hide resolved
@jo-basevi
Copy link
Collaborator Author

As there were merge conflicts, I rebased the branch onto latest changes on the main

Copy link
Collaborator

@aidanheerdegen aidanheerdegen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks.

@jo-basevi jo-basevi merged commit 3a9d09a into payu-org:master Sep 29, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Need for absolute paths when doing a payu clone -r could be clearer
4 participants