-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix clone with relative restart paths #516
Fix clone with relative restart paths #516
Conversation
Hello @jo-basevi! Thanks for updating this PR. We checked the lines you've touched for PEP 8 issues, and found: There are currently no PEP 8 issues detected in this Pull Request. Cheers! 🍻 Comment last updated at 2024-09-25 23:21:02 UTC |
7ac464e
to
6b86c14
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Just one clarifying question.
6b86c14
to
2c48e3c
Compare
As there were merge conflicts, I rebased the branch onto latest changes on the main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Added a fix for
payu clone -r
to resolve relative restart paths - with respect to the directory wherepayu clone
is run from. I've changed it to call the helper method that checks restart path exists and resolves to an absolute path, before changing directory to the cloned repository which runs thecheckout
step.Closes #514