Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feedback for ShoppingAnalytics #117

Open
4 tasks
ukalbhor opened this issue May 24, 2021 · 0 comments
Open
4 tasks

Feedback for ShoppingAnalytics #117

ukalbhor opened this issue May 24, 2021 · 0 comments

Comments

@ukalbhor
Copy link
Collaborator

ukalbhor commented May 24, 2021 •
edited
Loading

  • The page_type for home should be HOME instead of HOME_PAGE
  • In confluence as well as in the SDK code, it should be a plural user_tags instead of user_tag
  • Can simplify viewPage so it's signature is viewPage("HOME", {})
  • Can merge viewPage and viewProduct into viewPage("PRODUCT", {})
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ukalbhor