Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lexicalEditor is missing localized admin.placeholder #10518

Closed
HarleySalas opened this issue Jan 12, 2025 · 2 comments · Fixed by #10523
Closed

lexicalEditor is missing localized admin.placeholder #10518

HarleySalas opened this issue Jan 12, 2025 · 2 comments · Fixed by #10523
Labels
area: ui Related to the admin panel. created-by: Contributor

Comments

@HarleySalas
Copy link
Contributor

Describe the Bug.

Despite other Payload fields including localized placeholders, the lexicalEditor only supports a string in it's admin.placeholder property.

Image

Reproduction Steps

add an object with locale keys to lexicalEditor's admin.placeholder property

Environment Info

Payload 3.16.0
@HarleySalas HarleySalas added area: ui Related to the admin panel. status: needs-triage Possible bug which hasn't been reproduced yet labels Jan 12, 2025
@akhrarovsaid akhrarovsaid mentioned this issue Jan 12, 2025
Merged
AlessioGr pushed a commit that referenced this issue Jan 12, 2025
@akhrarovsaid
fix(richtext-lexical): adds support for localized placeholder (#10523)
dc6d79e 
### What?
This PR fixes a minor issue in `richtext-lexical` where editor
placeholders were not localized.

### Why?
To allow users to localize placeholders accordingly with their language
preferences in config.

### How?
By evaluating the placeholder in the editor RSC, if any is provided. The
`ContentEditable` component falls back to a default in the event that no
placeholder was provided as this was the existing behavior.

Fixes #10518
@github-actions github-actions bot removed the status: needs-triage Possible bug which hasn't been reproduced yet label Jan 12, 2025
@github-actions GitHub Actions
Copy link
Contributor

🚀 This is included in version v3.17.0

@github-actions GitHub Actions
Copy link
Contributor

This issue has been automatically locked.
Please open a new issue if this issue persists with any additional detail.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 15, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
area: ui Related to the admin panel. created-by: Contributor
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(richtext-lexical): adds support for localized placeholder akhrarovsaid/payload
1 participant
@HarleySalas