static constant as Array size

[samphunter]

const Size = 5;
new data[Size]; // Works fine

static const Size = 5;
new data[Size]; // error 008: must be a constant expression; assumed zero

[YashasSamaga]

The compiler treats static constants as "variables". Since, it is considered to be a variable instead of a constant, you are getting that error.

Static constants are declared as variables.
https://github.com/Zeex/pawn/blob/master/source/compiler/sc1.c#L4976
https://github.com/Zeex/pawn/blob/master/source/compiler/sc1.c#L2160

non-static constants are declared as constants.
https://github.com/Zeex/pawn/blob/master/source/compiler/sc1.c#L5050

findconst does not consider static constants as constants which is causing the problem.

[Daniel-Cortez]

Thanks to @VVWVV's work, starting from release 3.10.2 it's possible to use static enumerations to define constants with a scope limited to a single file.

static enum { ARRAY_SIZE = 20 };
new a[ARRAY_SIZE];

@Southclaws, you probably want to close this.

[YashasSamaga]

@Southclaws @Daniel-Cortez In my opinion, the issue is still not resolved. As const non-static variables can be used as array length, static const should also be allowed. Yes, there is another way out but the ability to use static const as an array argument isn't resolved.

As a matter of fact, we still can't create local static constants. Using a static enum would pollute the global namespace of the file when you just want the constant to remain visible just within a function or a block.

[Southclaws]

Ah I misread the post from Daniel and thought static const was resolved.

[Daniel-Cortez]

@YashasSamaga, so how do you imagine "fixing" this? Treat all identifiers defined with static const as compile-time constants instead of read-only variables? Such change can probably break existing code.

[Southclaws]

If const works, surely static const isn't much different? The only difference is the access constraint to the section/file it's in.

[YashasSamaga]

@Daniel-Cortez Hmm, I get your point. I think my own code will get screwed if static const is treated as compile-time constants because I access it through assembly.

Why not simply use the value of the static const variable as a compile-time constant and leave the variable as it is?

EDIT: I see. The fix is pretty complicated: will have to make a new entry or use an existing entry in the symbol structure to store the initialization value for local static constants.

[Southclaws]

If the fix is complicated, is this really worth the work? Symbolising constants with #define is good enough, right?