`#emit` stuck in previous block

[Y-Less]

Is this a BUG REPORT, FEATURE REQUEST or QUESTION?:

• Bug Report
• Feature Request
• Question

What happened:

new a;
if (FALSE)
    printf("hi");
#emit CONST.pri 42
#emit STOR.S.pri a
printf("%d", a);

Prints 0.

What you expected to happen:

Print 42.

How to reproduce it (as minimally and precisely as possible):

^

Anything else we need to know?:

The #emit code isn't properly scoped, so compiles as:

new a;
if (FALSE)
{
    printf("hi");
    #emit CONST.pri 42
    #emit STOR.S.pri a
}
printf("%d", a);

I didn't use explicit braces, but that doesn't matter. You can fix it with extra braces:

new a;
if (FALSE)
{
    printf("hi");
}
{}
#emit CONST.pri 42
#emit STOR.S.pri a
printf("%d", a);

I thought this was fixed long ago, but I just spent ages tracking down a bug that turned out to be caused by this.

Environment:

• Operating System
• Compiler version
• How are you invoking the compiler? Pawno, Sublime, vscode, sampctl or command-line?
• If using sampctl, the version number

[YashasSamaga]

main () {
   if(0)
	#emit CONST.pri 5
}

does not compile because #emit is a pre-processor directive and does not count as a statement?

[YashasSamaga]

if(expr)
{

}
#emit NOP
else
{

}

What exactly should happen?

If we assume that this situation would never arise (in other words, put the blame on the programmer for this kind of code), there's an easy fix for this bug.

[Y-Less]

That code is wrong, assuming there isn't another if above. So yes, that's clearly the programmer's fault.

[Y-Less]

Actually, that code would be wrong even if there was another if.

[YashasSamaga]

If the wrong code (described in my previous reply) is used, the wrong instructions won't be present in the binary. After applying the fix, this is how it compiles:

new a;
main () {
	if(a)
	{
    	#emit CONST.pri 1
    	#emit CONST.pri 2
	}
	#emit CONST.pri 3
	#emit CONST.pri 4
	
	if(a)
		a = 1;
	#emit CONST.pri 4
 	#emit CONST.pri 5
	
	if(a)
	{
	
	}
	#emit CONST.pri 6
	#emit CONST.pri 7
	
	if(a)
	{
		#emit CONST.pri 8
		#emit CONST.pri 9
 	}
 	else
 	{
 	    #emit CONST.pri 10
 	    #emit CONST.pri 11
 	}
 	#emit CONST.pri 12
 	#emit CONST.pri 13

 	if(0)
	{
    	#emit CONST.alt 1
    	#emit CONST.alt 2
	}
	#emit CONST.alt 3
	#emit CONST.alt 4

	if(0)
		a = 1;
	#emit CONST.alt 4
 	#emit CONST.alt 5

	if(0)
	{

	}
	#emit CONST.alt 6
	#emit CONST.alt 7

	if(0)
	{
		#emit CONST.alt 8
		#emit CONST.alt 9
 	}
 	else
 	{
 	    #emit CONST.alt 10
 	    #emit CONST.alt 11
 	}
 	
 	
 	#emit NOP
 	#emit NOP
 	
 	if(1)
 	{
 	    #emit LCTRL 1
 	    #emit LCTRL 2
 	}
 	#emit LCTRL 3
 	#emit LCTRL 4
 	else
 	{
 	    #emit LCTRL 5
 	    #emit LCTRL 6
 	}
}

CODE 0	; 0
;program exit point
	halt 0


DATA 0	; 0
dumpn 0 1

CODE 0	; 8
	proc	; main
	; line 2
	; line 3
	break	; c
	load.pri 0
	jzer 0
	;$exp
	const.pri 1
	const.pri 2
l.0
	const.pri 3
	const.pri 4
	; line b
	break	; 40
	load.pri 0
	jzer 1
	;$exp
	; line c
	break	; 54
	const.pri 1
	stor.pri 0
	;$exp
l.1
	const.pri 4
	const.pri 5
	; line 10
	break	; 78
	load.pri 0
	jzer 2
	;$exp
l.2
	const.pri 6
	const.pri 7
	; line 17
	break	; 9c
	load.pri 0
	jzer 3
	;$exp
	const.pri 8
	const.pri 9
	jump 4
l.3
	const.pri a
	const.pri b
l.4
	const.pri c
	const.pri d
	; line 24
	break	; e8
	jump 5
	const.alt 1
	const.alt 2
l.5
	const.alt 3
	const.alt 4
	; line 2c
	break	; 114
	jump 6
	; line 2d
	break	; 120
	const.pri 1
	stor.pri 0
	;$exp
l.6
	const.alt 4
	const.alt 5
	; line 31
	break	; 144
	jump 7
l.7
	const.alt 6
	const.alt 7
	; line 38
	break	; 160
	jump 8
	const.alt 8
	const.alt 9
	jump 9
l.8
	const.alt a
	const.alt b
l.9
	nop 
	nop 
	; line 47
	break	; 19c
	lctrl 1
	lctrl 2
	jump b
l.a
	lctrl 5
	lctrl 6
l.b
	zero.pri
	retn


STKSIZE 1000

[Y-Less]

Well that's wrong too, it should not compile.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.