src/regression_tracker: check for regression in all child nodes

When runner submits a hierarchy of nodes at a single shot,
the API will publish event just for parent node.
In that case, the parent node can have "pass" result,
even if one of its child has failed.
Tweak regression tracker to listen to events when "checkout"
node reaches to "done" state instead of getting nodes with
just "fail" result.
That way we can traverse through all the child nodes using
the checkout node and check for regressions.

Signed-off-by: Jeny Sadadia <[email protected]>

Author: Jeny Sadadia

Diff for: src/regression_tracker.py

@@ -27,7 +27,6 @@ def __init__(self, configs, args):
     def _setup(self, args):
         return self._api_helper.subscribe_filters({
             'state': 'done',
-            'result': 'fail',
         })
 
     def _stop(self, sub_id):
@@ -43,6 +42,38 @@ def _create_regression(self, failed_node, last_successful_node):
         regression['regression_data'] = [last_successful_node, failed_node]
         self._api_helper.submit_regression(regression)
 
+    def _detect_regression(self, node):
+        """Method to check and detect regression"""
+        previous_nodes = self._api.get_nodes({
+            'name': node['name'],
+            'group': node['group'],
+            'path': node['path'],
+            'revision.tree': node['revision']['tree'],
+            'revision.branch': node['revision']['branch'],
+            'revision.url': node['revision']['url'],
+            'created__lt': node['created'],
+        })
+
+        if previous_nodes:
+            previous_nodes = sorted(
+                previous_nodes,
+                key=lambda node: node['created'],
+                reverse=True
+            )
+
+            if previous_nodes[0]['result'] == 'pass':
+                self.log.info(f"Detected regression for node id: \
+{node['id']}")
+                self._create_regression(node, previous_nodes[0])
+
+    def _get_all_failed_child_nodes(self, failures, root_node):
+        """Method to get all failed nodes recursively from top-level node"""
+        child_nodes = self._api.get_nodes({'parent': root_node['id']})
+        for node in child_nodes:
+            if node['result'] == 'fail':
+                failures.append(node)
+            self._get_all_failed_child_nodes(failures, node)
+
     def _run(self, sub_id):
         """Method to run regression tracking"""
         self.log.info("Tracking regressions... ")
@@ -51,31 +82,15 @@ def _run(self, sub_id):
 
         while True:
             node = self._api_helper.receive_event_node(sub_id)
-            if not node['group']:
-                continue
-
-            previous_nodes = self._api.get_nodes({
-                'name': node['name'],
-                'group': node['group'],
-                'revision.tree': node['revision']['tree'],
-                'revision.branch': node['revision']['branch'],
-                'revision.url': node['revision']['url'],
-                'created__lt': node['created'],
-            })
 
-            if not previous_nodes:
+            if node['name'] == 'checkout':
                 continue
 
-            previous_nodes = sorted(
-                previous_nodes,
-                key=lambda node: node['created'],
-                reverse=True
-            )
+            failures = []
+            self._get_all_failed_child_nodes(failures, node)
 
-            if previous_nodes[0]['result'] == 'pass':
-                self.log.info(f"Detected regression for node id: \
-{node['id']}")
-                self._create_regression(node, previous_nodes[0])
+            for node in failures:
+                self._detect_regression(node)
 
             sys.stdout.flush()
         return True