Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Emoji causes issues in CMS #209

Closed
MartinP-C opened this issue Aug 28, 2018 · 2 comments
Closed

Emoji causes issues in CMS #209

MartinP-C opened this issue Aug 28, 2018 · 2 comments

Comments

@MartinP-C
Copy link

The emoji cause issues when using Siema in a third-party's CMS.
The script was included on the page (because of a change to fix #205), but the unicode character "😭" was causing errors within the CMS (I believe because of some encoding configuration the third-party had made). After removing these there were no problems.

Although it is not as nice an experience for developers using Siema, it may be better to have these removed for better compatibility.

@pawelgrzybek
Copy link
Owner

Hi.

Siema doesn't care what kind of content is inside a container. Emojis, photos, videos — doesn't matter. This must be related with some specific CMS that you use.

Thanks and have a great day :)

@MartinP-C
Copy link
Author

Apologies, I should have clarified.
Emoji in the actual Siema code e.g.: https://github.com/pawelgrzybek/siema/blob/master/src/siema.js#L18

Because the third-party does not allow externally hosted scripts we have to include Siema on the page as a script tag. It then errors on saving the page because of the emoji.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants