Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widget needs updating for compatibility with upcoming Discourse core changes (widget → Glimmer component) #1

Open
jeffbyrnes opened this issue Jul 5, 2024 · 4 comments

Comments

@jeffbyrnes
Copy link

Per a banner notification on our Discourse install, the Discord Widget needs to be updated from a “legacy widget” to a “Glimmer component”.

Here’s the Meta post about this.

It looks like the code needing changes is lines 33–52 of discord-widget.js.

@angusmcleod
Copy link
Member

Hey Jeff, it looks like you know what's going on here. Would you mind making a PR?

@jeffbyrnes
Copy link
Author

@angusmcleod I’m putting on quite a show, in that case! 😆

I did take a look at trying to do this myself, but my JS skills are badly atrophied (it’s been > 5 years since I wrote any JS). I could probably puzzle it out if I had time, but with a 1½ year old at home, that’s in short supply.

@Arkshine
Copy link
Contributor

I made a PR! #2 😊

@Alexei0403
Copy link

how can I run it-discourse-discord-widget

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants