Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

README.md is outdated #45

Open
mpiasta-ca opened this issue Jun 1, 2015 · 4 comments
Open

README.md is outdated #45

mpiasta-ca opened this issue Jun 1, 2015 · 4 comments

Comments

@mpiasta-ca
Copy link

  1. The current README file does not mention using a form-control class on the target field, but when not used, script throws error: show-errors element has no child input elements with a 'name' attribute and a 'form-control' class <div class="form-group" show-errors="">.

  2. Using .form-control class on a checkbox, ie. requiring a user to check that they agree with your terms and conditions, it's invalid bootstrap code for a checkbox. So the result is the checkbox has style applied to it that makes it look really messed up (appears gigantic and with a shadow border). Therefore, angular-bootstrap-show-errors should not rely on a form-control class being present.

Checkbox looks gigantic as a result of .form-group class

Checkbox without .form-control class:

Checkbox without the form-control class

@sfdeveloperhub
Copy link

+1. Facing the same issue.

@sargue
Copy link

sargue commented Mar 7, 2016

+1 here, anyone found a workaround for the checkboxes problem?

@brunolemos
Copy link

brunolemos commented Sep 8, 2016

Current workaround: Manually add the has-error class:

<form name="myFormName">
    <div class="form-group">
        <div class="checkbox" ng-class="{'has-error': myFormName.myCheckboxName.$invalid}">
            <label>
                <input type="checkbox" name="myCheckboxName"/>>
                <span>My checkbox label</span>
            </label>
        </div>
    </div>
</form>

@WuglyakBolgoink
Copy link

Up:

link is dead:

See the Bootstrap Form Validation Done Right in AngularJS blog post to read about the benefits of using this directive.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants