Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why .form-control is required? #44

Open
egorovpavel opened this issue Apr 28, 2015 · 2 comments
Open

why .form-control is required? #44

egorovpavel opened this issue Apr 28, 2015 · 2 comments

Comments

@egorovpavel
Copy link

there may be number of cases when this is not possible due to form markup. One possible solution is to use *[name] instead .form-control['name']

seems it breaks only one spec which tests .form-control class for existence. So there is no reason to restrict to .form-control.

just one of use cases may be directives similar to ui-select or other no standard form controls.
@egorovpavel egorovpavel mentioned this issue Apr 28, 2015
Open
@chrisfosterelli
Copy link

+1 because not requiring form-control would also mean that this would work on bootstrap radio buttons, which was added in 2.2.0 but reverted away from in 2.3.0.

@leoetlino
Copy link

FYI, this was broken to fix #13.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@egorovpavel @chrisfosterelli @leoetlino