Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation fails on macos runners in github actions #1308

Open
ptesavol opened this issue Dec 20, 2024 · 1 comment
Open

Installation fails on macos runners in github actions #1308

ptesavol opened this issue Dec 20, 2024 · 1 comment

Comments

@ptesavol
Copy link

Hi,

The installation of libdatachannelusing using vcpkg on macos runners of github actions fails 80% of time.

The reason is that configure_file() function of CMake does not seem to work properly in this environment. I created a testing project for the issue, and you can see the logs of a failing install of unmodified libdatachannel here: https://github.com/ptesavol/cilibdatachannel/actions/runs/12426561480/job/34695028838

I fixed the problem by adding a vcpkg overlay port that applies a patch that replaces the call to configure_file() in CMakeLists.txt with copying: https://github.com/ptesavol/cilibdatachannel/blob/main/overlayports/libdatachannel/fix-cmakelists.patch

You can see the logs of a working install that uses the patch here: https://github.com/ptesavol/cilibdatachannel/actions/runs/12426632287/job/34695202895

Could you also replace the configure_file() with copying in libdatachannel main so the overlay port would not be needed anymore?

@paullouisageneau
Copy link
Owner

version.h.in is a template, you should not copy it as-is, otherwise you would end up with the library built with version string @PROJECT_VERSION@.

This issue should be fixed in 0.22, have you tried updating?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants