-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expectation errors should be based on median run values #181
Comments
Hi, thank you for raising this question, I think it's a good idea 👍 |
should be fixed via #178 |
Any idea when #178 might be merged? |
Hi, @brophdawg11. Hope really soon, but need some polishing. Working on that... |
closing since #178 merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When performing multiple runs on a page with expectation set, the entire testing process will fail if any one of the runs exceeds any expectation value.
If the purpose of doing multiple runs is to gather several data points for performance metrics in order to rule out outliers and unrepresentative numbers, I think it makes sense that the pass/fail should be based on the median numbers for the runs (which are displayed at the end anyways).
What do you guys think? I'm happy to make a PR if we're okay with this.
The text was updated successfully, but these errors were encountered: