Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Table: revisit/verify mobile views for Penta #1290

Closed
srambach opened this issue Dec 21, 2023 · 5 comments
Closed

Table: revisit/verify mobile views for Penta #1290

srambach opened this issue Dec 21, 2023 · 5 comments
Assignees

Comments

@srambach
Copy link
Member

srambach commented Dec 21, 2023

          Currently we have this 8px border at narrow widths, but it's a lighter color (#f0f0f0) than when the border is only 1px thick. @andrew-ronaldson is this good for now or should we use a lighter gray for when the line is thick?

Originally posted by @srambach in patternfly/patternfly#6130 (comment)

One instance noted above, but in general we should verify the mobile behavior and check it with design.

@srambach srambach changed the title Currently we have this 8px border at narrow widths, but it's a lighter color (#f0f0f0) than when the border is only 1px thick. @andrew-ronaldson is this good for now or should we use a lighter gray for when the line is thick? Data List, Table: revisit/verify mobile views for Penta Dec 21, 2023
@srambach srambach added this to the 2024.Q1 milestone Dec 21, 2023
Copy link

stale bot commented Feb 20, 2024

This issue has been automatically marked as stale because it has not had activity in the last 60 days. It will be closed in 30 days if no further activity occurs.

@kmcfaul kmcfaul changed the title Data List, Table: revisit/verify mobile views for Penta Table: revisit/verify mobile views for Penta Mar 12, 2024
@kmcfaul
Copy link

kmcfaul commented Mar 12, 2024

Moving DataList verification to a separate issue #1291

@kmcfaul kmcfaul transferred this issue from patternfly/patternfly Apr 9, 2024
@kmcfaul kmcfaul moved this from Ready to assign to Not started in PatternFly Issues Apr 10, 2024
@kaylachumley
Copy link
Collaborator

@srambach same change for datalist! default border color is good. It looks like the border width is fine on mobile now. I did notice a bug with the expandable row from desktop to mobile but i think that needs to be put on a different issue. I don't see an issue for that already so I'll ping the pf-scrum channel to make note of it

@srambach
Copy link
Member Author

Core issue: patternfly/patternfly#6556

@andrew-ronaldson
Copy link

Closing with core issue patternfly/patternfly#6556

@github-project-automation github-project-automation bot moved this from PR Review to Done in PatternFly Issues Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

4 participants