Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transform dic_lipids.py into json files #48

Closed
4 of 5 tasks
HubLot opened this issue Jan 7, 2021 · 5 comments · Fixed by #54
Closed
4 of 5 tasks

Transform dic_lipids.py into json files #48

HubLot opened this issue Jan 7, 2021 · 5 comments · Fixed by #54
Assignees

Comments

@HubLot
Copy link
Collaborator

HubLot commented Jan 7, 2021

After thorough discussion, it will be better to transform the dic_lipids.py into json files.
This dic_lipids.py is used to reconstructed hydrogens from a united atom bilayer.

This will allow the users to add their own .json files for their own trajectories.
A regular database of json will be created in the buildH source code into a directory called lipids to provide a set of supported lipids.
We will add an option to the program for user to provided their own json.

Steps:

  • Convert the current dic_lipids.py into a series of .json files into buildh/lipids directory
  • Transform the code to read those json files
  • Provide a list of supported lipids when using the -h of the program (by parsing the directory)
  • Add an argument for users to provide their own .json files.
  • Integrate the lipids from NMRLipids@d0a2bc1 (issue Add json files for other UA force fields and lipids #44)
@HubLot HubLot self-assigned this Jan 7, 2021
@HubLot HubLot changed the title Transform dic_lipids.py into json Transform dic_lipids.py into json files Jan 7, 2021
@patrickfuchs patrickfuchs self-assigned this Jan 7, 2021
@HubLot HubLot linked a pull request Jan 11, 2021 that will close this issue
@patrickfuchs patrickfuchs reopened this Jan 20, 2021
@patrickfuchs
Copy link
Owner

I reopen this issue because we're not done yet. I checked what's been done above. I think the most urgent thing is to implement Provide a list of supported lipids when using the -h. We can discuss it this afternoon.

@HubLot
Copy link
Collaborator Author

HubLot commented Jan 20, 2021

It's done ;)
It's within the epilog of the ArgumentParser constructor:

buildH/buildh/cli.py

Lines 132 to 134 in 6c79661

epilog = f"The list of supported lipids (-l option) are: {lipids_supported_str}."
parser = argparse.ArgumentParser(description=message,
epilog=epilog)

$ buildH -h
[...]
  -e END, --end END     The last frame (ps) to read from the trajectory.
  -pi PICKLE, --pickle PICKLE
                        Output pickle filename. The structure pickled is a dictonnary containing for each Order
                        parameter, the value of each lipid and each frame as a matric

The list of supported lipids (-l option) are: CHARMM_POPC, Berger_POP, Berger_POPC, Berger_PLA.

@HubLot
Copy link
Collaborator Author

HubLot commented Jan 20, 2021

but the issue #44 is not done.

@patrickfuchs
Copy link
Owner

Oops sorry 😁... Great, so I can incorporate that into the first notebook. I checked the corresponding checkboxes up there.
So indeed, what is left to do is adding new lipids (#44). Almost there!

@patrickfuchs
Copy link
Owner

We close this issue since it's redundant with #44 at this stage.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants