Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for silent operation #29

Open
ianseyer opened this issue Feb 18, 2022 · 2 comments
Open

Add support for silent operation #29

ianseyer opened this issue Feb 18, 2022 · 2 comments
Labels
community-feedback Asking the community what the best solution might be enhancement New feature or request

Comments

@ianseyer
Copy link
Contributor

Hello,

I am using this module as a static library, for use within a Go application.

It would be great to be able to create a Split object that is silent (i.e. does not print anything to StdErr).

@patrickdappollonio
Copy link
Owner

Hey @ianseyer!

Thanks a lot for this, appreciate the PR as well!

I think I'll merge the PR but keep this issue open. I think there could be a bit of a better way to handle it for any other resource coming forward -- knowing that the app could continue to grow. I'm thinking something along the lines of having an io.Writer where if -q is enabled then it would simply set the writer to something like ioutil.Discard. That, or a logging library of some sorts.

Thanks a lot for your contribution!

@patrickdappollonio patrickdappollonio added community-feedback Asking the community what the best solution might be enhancement New feature or request labels Feb 18, 2022
@patrickdappollonio
Copy link
Owner

Hey @ianseyer!

I'm planning to retake some of this soon. In the meantime, I'm also planning to add #66 however just in the CLI side of things. I imagine you want to keep it to your own settings, so it won't be a "package-related change" (to the slice package) but instead just to the CLI.

Just giving you the heads-up in case you have any concerns. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-feedback Asking the community what the best solution might be enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants