-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Components of size should be part_of rather than Is_a children #246
Comments
Hey @cooperl09 Not quite sure I follow: in my (albeit very limited) world view diameter is a kind of size; or are you referring to the fact that an increased diameter does not automatically imply an increased size? |
IMHO, an increased diameter is only one aspect of increased size. Height, length, thickness etc are all aspects (part_of) of size as well. |
Ontologically speaking, you are probably right. Although |
It also seems odd that diameter (PATO:0001334) is a child of length (PATO:0000122). |
much as I hate proliferation of similar terms there is an argument for a 'size attribute' grouping class and then being stricter about size as Laurel suggests |
I am not comfortable with these issues and defer them to my boss :P @dosumis |
The components of size (PATO:0000117); the terms for 1-D extent, 2-D extent and 3-D extent should all be should be part_of size, rather than Is_a children.
Currently in PATO, length, width and diameter are all direct children of size.
Thus leads to weird inferences, such as stem diameter (TO:0020083) is a stem size (TO:0000892), in the Planteome.
See: Planteome/plant-trait-ontology#447
The text was updated successfully, but these errors were encountered: