Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to draw layout associated to register on the same plot as the Register #726

Open
a-corni opened this issue Aug 28, 2024 · 5 comments · May be fixed by #772
Open

Add option to draw layout associated to register on the same plot as the Register #726

a-corni opened this issue Aug 28, 2024 · 5 comments · May be fixed by #772
Assignees
@BrFle
Labels
good first issue Good for newcomers

Comments

@a-corni
Copy link
Collaborator

a-corni commented Aug 28, 2024 •
edited
Loading

It is currently hard to visualize what trapping spots have been selected among a layout to define a Register. The layout is stored inside a register. With the option "qubits_color", we can implement the plotting of both layout and register on the same plot:
image
Suggested by both @SergiJulia94 and @soufianekaghad98
@HGSilveri HGSilveri added the good first issue Good for newcomers label Sep 18, 2024
@BrFle
Copy link

BrFle commented Oct 2, 2024 •
edited
Loading

Hey ! I'd like to start contributing to Pulser, can I be assigned this issue ?

@HGSilveri
Copy link
Collaborator

Hey @BrFle , of course! Let us know if you need any help :)

@HGSilveri HGSilveri added this to the v1.2 milestone Nov 22, 2024
@a-corni
Copy link
Collaborator Author

a-corni commented Dec 2, 2024

Hi @BrFle, do you need help to tackle this issue ? 😄

@BrFle
Copy link

BrFle commented Dec 3, 2024 •
edited
Loading

Hi @BrFle, do you need help to tackle this issue ? 😄

Hey @a-corni ! I got confused with git and actually never published my PR. I got something working, i'm still lacking reasonable tests. Could you go take a look ?
Thanks a lot !
#772

@a-corni
Copy link
Collaborator Author

a-corni commented Dec 3, 2024

Thanks @BrFle ! I will have a look !

@a-corni a-corni linked a pull request Dec 3, 2024 that will close this issue
Open
@HGSilveri HGSilveri removed this from the v1.2 milestone Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@BrFle BrFle

Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Draw layout and register on the same plot BrFle/Pulser
3 participants
@BrFle @HGSilveri @a-corni