Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vaadin 8 support #26

Open
tstsogoo opened this issue Feb 6, 2017 · 6 comments
Open

Vaadin 8 support #26

tstsogoo opened this issue Feb 6, 2017 · 6 comments

Comments

@tstsogoo
Copy link

tstsogoo commented Feb 6, 2017

No description provided.

@WoozyG
Copy link
Contributor

WoozyG commented Mar 1, 2017

I've taken a stab at V8 support:

https://github.com/WoozyG/easyuploads

haven't figured out running the tests yet though. The widgetset compiles cleanly. Help welcome.

@mstahv
Copy link
Collaborator

mstahv commented Mar 1, 2017

Cool!

First thing to do is to update this into latest what you find form the Directory:
https://github.com/parttio/easyuploads/blob/master/pom.xml#L312

Then run the main method from this class:
https://github.com/parttio/easyuploads/blob/master/src/test/java/org/vaadin/easyuploads/demoandtestapp/UiRunner.java

That starts a web server with all usage examples are listed for manual testing. I don't remember if there is too many Selenium scripts in this project. You could see that the functionality is the same as in Vaadin 7 version.

Also you could see that the SCM connections are updated to parttio/easyuploads. After that, create a pull request and if you ever happen to meet me at a Vaadin meetup or conference, let me buy you a beer :-)

cheers,
matti

@WoozyG
Copy link
Contributor

WoozyG commented Mar 2, 2017

I'll work on that, after I get my project back up and running with Vaadin 8. Everything works except Grid from inside a declarative design. For some reason it is throwing client-side exceptions before it gets a chance for the server to configure the grid. Hmm.

I'm not a proficient Maven user, but I'll give your instructions a shot and get a pull request together hopefully tomorrow, if I can sort out my Grid issue.

@WoozyG
Copy link
Contributor

WoozyG commented Mar 3, 2017

When I try to run the UiRunner class, I get this error:

2017-03-02 17:00:14.654:WARN::FAILED o.e.j.w.WebAppContext{/,file:/C:/Users/GregWoolsey/git/easyuploads/target/testwebapp/},target\testwebapp: java.lang.NoSuchMethodError: com.vaadin.server.VaadinServletService.addSessionInitListener(Lcom/vaadin/server/SessionInitListener;)V
2017-03-02 17:00:14.654:WARN::Error starting handlers
java.lang.NoSuchMethodError: com.vaadin.server.VaadinServletService.addSessionInitListener(Lcom/vaadin/server/SessionInitListener;)V
	at org.vaadin.addonhelpers.TServer$1.init(TServer.java:42)

However the Vaadin 8 jars are on the classpath for the test at runtime. Do I need a newer version of something? I'm using essentially the POM from trunk, plus the Vaadin 7 compatibility libraries and Vaadin 8 instead of 7.

@TheItachiUchiha
Copy link

According to https://vaadin.com/directory#!addon/easyuploads using the following dependency should work for Vaadin 8:

<dependency>
   <groupId>org.vaadin.addon</groupId>
   <artifactId>easyuploads</artifactId>
   <version>8.0.0</version>
</dependency>

But, using the add-on with my Vaadin 8 application breaks it with the following error:

[INFO] [org.gradle.api.Project] Loading inherited module 'org.vaadin.easyuploads.Widgetset'
[INFO] [org.gradle.api.Project] Loading inherited module 'com.vaadin.v7.Vaadin7WidgetSet'
[ERROR] [org.gradle.api.Project] Unable to find 'com/vaadin/v7/Vaadin7WidgetSet.gwt.xml' on your classpath; could be a typo, or maybe you forgot to include a classpath entry for source?

Does this mean that the add-on is still not completely supported by Vaadin 8 or am I missing something?

@mstahv
Copy link
Collaborator

mstahv commented Apr 21, 2017

You will also need this:

<dependency>
   <groupId>com.vaadin</groupId>
   <artifactId>vaadin-compatibility-client</artifactId>
   <scope>provided</scope>
</dependency>

I wouldn't like to add that as direct dependency as that don't need to be on the classpath during runtime. I'll add a note to the directory.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants