Skip to content
This repository has been archived by the owner on May 13, 2024. It is now read-only.

Disable false positive (rules that doesn't work for our components,...) #10

Open
jcgueriaud1 opened this issue Sep 22, 2023 · 2 comments

Comments

@jcgueriaud1
Copy link
Collaborator

Sometimes the tool is generating false positive.
For example:
Rule ID: input_label_before
Label text is located after its associated text input or element What to do Place the text of the label immediately before the text input or element.
In our component, the error message slot is in between.
image

@jcgueriaud1
Copy link
Collaborator Author

We probably need a function to filter the results globally instead of a simple if like:

// Remove passing issues
        accessibilityCheckResult.results = accessibilityCheckResult.results.filter(
            (issues: RuleDetails) => {
                return issues.value[1] !== "PASS"
                    && !issues.path.dom.includes("vaadin-dev-tools")
                    && !issues.path.dom.includes("vite-plugin-checker-error-overlay")
                    && !issues.path.dom.includes("vaadin-connection-indicator");}
        );

@jcgueriaud1
Copy link
Collaborator Author

It would be great to be able to configure an ignore list

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant