Skip to content

Commit b640722

Browse files
feat: change parquet compression algorithm (#1145)
default algorithm changed from lz4 to lz4raw because lz4 is deprecated details here - https://issues.apache.org/jira/browse/PARQUET-2032
1 parent 5294779 commit b640722

File tree

3 files changed

+8
-6
lines changed

3 files changed

+8
-6
lines changed

src/cli.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -260,7 +260,7 @@ pub struct Options {
260260
#[arg(
261261
long = "compression-algo",
262262
env = "P_PARQUET_COMPRESSION_ALGO",
263-
default_value = "lz4",
263+
default_value = "lz4_raw",
264264
value_parser = validation::compression,
265265
help = "Parquet compression algorithm"
266266
)]

src/correlation.rs

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,10 +129,9 @@ impl Correlations {
129129
.await?;
130130

131131
// Update in memory
132-
self.write().await.insert(
133-
correlation.id.to_owned(),
134-
correlation.clone(),
135-
);
132+
self.write()
133+
.await
134+
.insert(correlation.id.to_owned(), correlation.clone());
136135

137136
Ok(correlation)
138137
}

src/option.rs

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -168,8 +168,9 @@ pub enum Compression {
168168
Gzip,
169169
Lzo,
170170
Brotli,
171-
#[default]
172171
Lz4,
172+
#[default]
173+
Lz4Raw,
173174
Zstd,
174175
}
175176

@@ -182,6 +183,7 @@ impl From<Compression> for parquet::basic::Compression {
182183
Compression::Lzo => parquet::basic::Compression::LZO,
183184
Compression::Brotli => parquet::basic::Compression::BROTLI(BrotliLevel::default()),
184185
Compression::Lz4 => parquet::basic::Compression::LZ4,
186+
Compression::Lz4Raw => parquet::basic::Compression::LZ4_RAW,
185187
Compression::Zstd => parquet::basic::Compression::ZSTD(ZstdLevel::default()),
186188
}
187189
}
@@ -277,6 +279,7 @@ pub mod validation {
277279
"lzo" => Ok(Compression::Lzo),
278280
"brotli" => Ok(Compression::Brotli),
279281
"lz4" => Ok(Compression::Lz4),
282+
"lz4_raw" => Ok(Compression::Lz4Raw),
280283
"zstd" => Ok(Compression::Zstd),
281284
_ => Err("Invalid COMPRESSION provided".to_string()),
282285
}

0 commit comments

Comments
 (0)