refactor: remove bool comparisons to decrease build times (#317)

parse-community · Jan 15, 2022 · b2a0d9c · b2a0d9c
1 parent b92667f
commit b2a0d9c
Show file tree

Hide file tree

Showing 5 changed files with 8 additions and 8 deletions.
diff --git a/Sources/ParseSwift/Extensions/URLSession.swift b/Sources/ParseSwift/Extensions/URLSession.swift
@@ -66,7 +66,7 @@ internal extension URLSession {
                     return .failure(error)
                 }
                 guard let parseError = error as? ParseError else {
-                    guard JSONSerialization.isValidJSONObject(responseData) == true,
+                    guard JSONSerialization.isValidJSONObject(responseData),
                           let json = try? JSONSerialization
                             .data(withJSONObject: responseData,
                               options: .prettyPrinted) else {

diff --git a/Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift b/Sources/ParseSwift/LiveQuery/ParseLiveQuery.swift
@@ -54,7 +54,7 @@ public final class ParseLiveQuery: NSObject {
     //Task
     var task: URLSessionWebSocketTask! {
         willSet {
-            if newValue == nil && isSocketEstablished == true {
+            if newValue == nil && isSocketEstablished {
                 isSocketEstablished = false
             }
         }
@@ -79,7 +79,7 @@ Not attempting to open ParseLiveQuery socket anymore
     }
     var isDisconnectedByUser = false {
         willSet {
-            if newValue == true {
+            if newValue {
                 isConnected = false
             }
         }
@@ -110,7 +110,7 @@ Not attempting to open ParseLiveQuery socket anymore
     /// True if the connection to the url is up and available. False otherwise.
     public internal(set) var isSocketEstablished = false { //URLSession has an established socket
         willSet {
-            if newValue == false {
+            if !newValue {
                 isConnected = newValue
             }
         }

diff --git a/Sources/ParseSwift/Objects/ParseUser.swift b/Sources/ParseSwift/Objects/ParseUser.swift
@@ -1074,7 +1074,7 @@ extension ParseUser {
         }
         var mutableSelf = self
         if let currentUser = Self.current,
-           currentUser.hasSameObjectId(as: mutableSelf) == true {
+           currentUser.hasSameObjectId(as: mutableSelf) {
             #if !os(Linux) && !os(Android) && !os(Windows)
             // swiftlint:disable:next line_length
             if let currentUserContainerInKeychain: CurrentUserContainer<BaseParseUser> = try? KeychainStore.shared.get(valueFor: ParseStorage.Keys.currentUser),
@@ -1103,7 +1103,7 @@ extension ParseUser {
         }
         var mutableSelf = self
         if let currentUser = Self.current,
-           currentUser.hasSameObjectId(as: mutableSelf) == true {
+           currentUser.hasSameObjectId(as: mutableSelf) {
             #if !os(Linux) && !os(Android) && !os(Windows)
             // swiftlint:disable:next line_length
             if let currentUserContainerInKeychain: CurrentUserContainer<BaseParseUser> = try? KeychainStore.shared.get(valueFor: ParseStorage.Keys.currentUser),

diff --git a/Sources/ParseSwift/Parse.swift b/Sources/ParseSwift/Parse.swift
@@ -354,7 +354,7 @@ public struct ParseSwift {
         #if !os(Linux) && !os(Android) && !os(Windows)
         // Clear items out of the Keychain on app first run.
         if UserDefaults.standard.object(forKey: ParseConstants.bundlePrefix) == nil {
-            if Self.configuration.isDeletingKeychainIfNeeded == true {
+            if Self.configuration.isDeletingKeychainIfNeeded {
                 try? KeychainStore.old.deleteAll()
                 try? KeychainStore.shared.deleteAll()
             }

diff --git a/Sources/ParseSwift/Types/ParseError.swift b/Sources/ParseSwift/Types/ParseError.swift
@@ -473,7 +473,7 @@ public extension Error {
      */
     func containedIn(_ errorCodes: [ParseError.Code]) -> ParseError? {
         guard let error = self as? ParseError,
-              errorCodes.contains(error.code) == true else {
+              errorCodes.contains(error.code) else {
             return nil
         }
         return error