From 08ed6446f937c2ac79cb5fbbd6fc4bd0ff698de5 Mon Sep 17 00:00:00 2001 From: Manuel Trezza <5673677+mtrezza@users.noreply.github.com> Date: Wed, 25 Dec 2024 03:44:20 +0100 Subject: [PATCH 1/8] add lint --- .github/workflows/ci.yml | 23 +++++++++++++++++++++++ Parse/Parse.csproj | 4 ++++ 2 files changed, 27 insertions(+) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4a677f2c..4d23b404 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -8,6 +8,29 @@ on: paths-ignore: - '**/**.md' jobs: + lint: + name: Lint + runs-on: ubuntu-latest + steps: + - name: Checkout code + uses: actions/checkout@v4 + - name: Set up .NET + uses: actions/setup-dotnet@v4 + with: + dotnet-version: 6.0 + - name: Install dependencies + run: dotnet restore + - name: Run linting + run: dotnet build --no-restore --configuration Release /warnaserror + env: + DOTNET_CLI_TELEMETRY_OPTOUT: 1 + DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1 + - name: Save linting logs + if: failure() + uses: actions/upload-artifact@v4 + with: + name: stylecop-lint-log + path: lint-output.log check-dotnet: strategy: matrix: diff --git a/Parse/Parse.csproj b/Parse/Parse.csproj index 4e098693..d0085628 100644 --- a/Parse/Parse.csproj +++ b/Parse/Parse.csproj @@ -27,6 +27,10 @@ + + + + From 21f0bb80f5a15366eaead25efb903fdcb306d57e Mon Sep 17 00:00:00 2001 From: Manuel Trezza <5673677+mtrezza@users.noreply.github.com> Date: Wed, 25 Dec 2024 03:45:11 +0100 Subject: [PATCH 2/8] Update ci.yml --- .github/workflows/ci.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 4d23b404..3de4b883 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -12,7 +12,7 @@ jobs: name: Lint runs-on: ubuntu-latest steps: - - name: Checkout code + - name: Checkout repository uses: actions/checkout@v4 - name: Set up .NET uses: actions/setup-dotnet@v4 @@ -42,7 +42,7 @@ jobs: steps: - name: Checkout repository uses: actions/checkout@v4 - - name: Set up .NET SDK + - name: Set up .NET uses: actions/setup-dotnet@v4 with: dotnet-version: ${{ matrix.DOTNET_VERSION }} From d5cef7ed6d643e184df827362259bd8af46131b0 Mon Sep 17 00:00:00 2001 From: Manuel Trezza <5673677+mtrezza@users.noreply.github.com> Date: Wed, 25 Dec 2024 03:45:49 +0100 Subject: [PATCH 3/8] Update ci.yml --- .github/workflows/ci.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 3de4b883..9ba8a9a9 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -17,7 +17,7 @@ jobs: - name: Set up .NET uses: actions/setup-dotnet@v4 with: - dotnet-version: 6.0 + dotnet-version: '6.0' - name: Install dependencies run: dotnet restore - name: Run linting From dbe30f73fd9749c1968dc779fc04ef34685d0b4c Mon Sep 17 00:00:00 2001 From: Manuel Trezza <5673677+mtrezza@users.noreply.github.com> Date: Wed, 25 Dec 2024 03:47:06 +0100 Subject: [PATCH 4/8] Update ci.yml --- .github/workflows/ci.yml | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 9ba8a9a9..da52e66f 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -10,7 +10,7 @@ on: jobs: lint: name: Lint - runs-on: ubuntu-latest + runs-on: windows-latest steps: - name: Checkout repository uses: actions/checkout@v4 @@ -20,6 +20,15 @@ jobs: dotnet-version: '6.0' - name: Install dependencies run: dotnet restore + - name: Cache NuGet packages + uses: actions/cache@v4 + with: + path: | + ~/.nuget/packages + ~/.local/share/NuGet/Cache + key: ${{ runner.os }}-nuget-${{ hashFiles('**/*.csproj') }} + restore-keys: | + ${{ runner.os }}-nuget- - name: Run linting run: dotnet build --no-restore --configuration Release /warnaserror env: From a1f862ca1e39c7520a89f8bdc3beaba32ccc4d3c Mon Sep 17 00:00:00 2001 From: Manuel Trezza <5673677+mtrezza@users.noreply.github.com> Date: Wed, 25 Dec 2024 03:47:56 +0100 Subject: [PATCH 5/8] Update ci.yml --- .github/workflows/ci.yml | 57 ++++++++++++++++++++-------------------- 1 file changed, 29 insertions(+), 28 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index da52e66f..af23b3fa 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,35 +11,36 @@ jobs: lint: name: Lint runs-on: windows-latest + timeout-minutes: 15 steps: - - name: Checkout repository - uses: actions/checkout@v4 - - name: Set up .NET - uses: actions/setup-dotnet@v4 - with: - dotnet-version: '6.0' - - name: Install dependencies - run: dotnet restore - - name: Cache NuGet packages - uses: actions/cache@v4 - with: - path: | - ~/.nuget/packages - ~/.local/share/NuGet/Cache - key: ${{ runner.os }}-nuget-${{ hashFiles('**/*.csproj') }} - restore-keys: | - ${{ runner.os }}-nuget- - - name: Run linting - run: dotnet build --no-restore --configuration Release /warnaserror - env: - DOTNET_CLI_TELEMETRY_OPTOUT: 1 - DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1 - - name: Save linting logs - if: failure() - uses: actions/upload-artifact@v4 - with: - name: stylecop-lint-log - path: lint-output.log + - name: Checkout repository + uses: actions/checkout@v4 + - name: Set up .NET + uses: actions/setup-dotnet@v4 + with: + dotnet-version: '6.0' + - name: Install dependencies + run: dotnet restore + - name: Cache NuGet packages + uses: actions/cache@v4 + with: + path: | + ~/.nuget/packages + ~/.local/share/NuGet/Cache + key: ${{ runner.os }}-nuget-${{ hashFiles('**/*.csproj') }} + restore-keys: | + ${{ runner.os }}-nuget- + - name: Run linting + run: dotnet build --no-restore --configuration Release /warnaserror + env: + DOTNET_CLI_TELEMETRY_OPTOUT: 1 + DOTNET_SKIP_FIRST_TIME_EXPERIENCE: 1 + - name: Save linting logs + if: failure() + uses: actions/upload-artifact@v4 + with: + name: stylecop-lint-log + path: lint-output.log check-dotnet: strategy: matrix: From 4e00d9078585b3823258fbfdfb725c581075868b Mon Sep 17 00:00:00 2001 From: Manuel Trezza <5673677+mtrezza@users.noreply.github.com> Date: Wed, 25 Dec 2024 04:08:11 +0100 Subject: [PATCH 6/8] Create stylecop.json --- Parse/stylecop.json | 7 +++++++ 1 file changed, 7 insertions(+) create mode 100644 Parse/stylecop.json diff --git a/Parse/stylecop.json b/Parse/stylecop.json new file mode 100644 index 00000000..297a7072 --- /dev/null +++ b/Parse/stylecop.json @@ -0,0 +1,7 @@ +{ + "settings": { + "documentationRules": { + "documentPublicElements": false + } + } +} From 06bc9d03a45057a3cc929fa0241dea71e25ddf4d Mon Sep 17 00:00:00 2001 From: Manuel Trezza <5673677+mtrezza@users.noreply.github.com> Date: Wed, 25 Dec 2024 04:10:43 +0100 Subject: [PATCH 7/8] Update stylecop.json --- Parse/stylecop.json | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/Parse/stylecop.json b/Parse/stylecop.json index 297a7072..0f230df8 100644 --- a/Parse/stylecop.json +++ b/Parse/stylecop.json @@ -1,7 +1,10 @@ { "settings": { - "documentationRules": { - "documentPublicElements": false - } + "documentationRules": { + "documentPublicElements": false + }, + "layoutRules": { + "ignoreSpacesAroundParentheses": true + } } } From dd1f26cfb6d3a387a0e50628ad886c4d7335eb2a Mon Sep 17 00:00:00 2001 From: Manuel Trezza <5673677+mtrezza@users.noreply.github.com> Date: Wed, 25 Dec 2024 04:12:46 +0100 Subject: [PATCH 8/8] Update stylecop.json --- Parse/stylecop.json | 22 +++++++++++++++------- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/Parse/stylecop.json b/Parse/stylecop.json index 0f230df8..590850cf 100644 --- a/Parse/stylecop.json +++ b/Parse/stylecop.json @@ -1,10 +1,18 @@ { - "settings": { - "documentationRules": { - "documentPublicElements": false - }, - "layoutRules": { - "ignoreSpacesAroundParentheses": true + "settings": { + "documentationRules": { + "documentPublicElements": false + }, + "layoutRules": { + "ignoreSpacesAroundParentheses": true + }, + "orderingRules": { + "elementOrder": [ + "kind", + "accessibility", + "static" + ], + "ignoreAccessModifiers": true + } } - } }