Skip to content
This repository was archived by the owner on Nov 15, 2023. It is now read-only.

MODULE_ID should be configurable #5149

Closed
shawntabrizi opened this issue Mar 5, 2020 · 2 comments · Fixed by #5695
Closed

MODULE_ID should be configurable #5149

shawntabrizi opened this issue Mar 5, 2020 · 2 comments · Fixed by #5695
Assignees
@emostov
Labels
J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.

Comments

@shawntabrizi
Copy link
Member

shawntabrizi commented Mar 5, 2020 •
edited
Loading

Some pallets introduce a MODULE_ID which is hard-coded into the runtime.

These are usually used as a seed for generating a unique account id for those pallets to hold funds (like a POT).

This pattern is not flexible, and immediately makes it so that these pallets could not be made instantiable.

It would be better to have these as configuration traits, and even better, to have them auto-populated based on the ModuleToString: #5148
@shawntabrizi shawntabrizi added J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be. labels Mar 6, 2020
@stanislav-tkach stanislav-tkach self-assigned this Mar 10, 2020
@emostov
Copy link
Contributor

emostov commented Apr 13, 2020

I was interested in working on this issue but noticed DarkEld3r self-assigned over a month ago. If there has been no progress on this issue, can I have it assigned to myself?

@shawntabrizi
Copy link
Member Author

@emostov I think that should not be a problem. Ill assign you

@emostov emostov mentioned this issue Apr 18, 2020
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@emostov emostov

Labels
J0-enhancement An additional feature request. Z1-easy Can be fixed primarily by duplicating and adapting code by an intermediate coder Z6-mentor An easy task where a mentor is available. Please indicate in the issue who the mentor could be.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Make Pallet ModuleId and LockIdentifier Configurable emostov/substrate
3 participants
@shawntabrizi @stanislav-tkach @emostov