Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove usage of AccountKeyring #5858

Open
2 tasks done
programskillforverification opened this issue Sep 27, 2024 · 2 comments
Open
2 tasks done

Remove usage of AccountKeyring #5858

programskillforverification opened this issue Sep 27, 2024 · 2 comments
Labels
I5-enhancement An additional feature request.

Comments

@programskillforverification
Copy link
Contributor

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Motivation

https://github.com/paritytech/polkadot-sdk/blob/master/substrate/primitives/keyring/src/lib.rs#L34
Compared with AccountKeyring, Sr25519Keyring and Ed25519Keyring are more intuitive.
When both Sr25519Keyring and Ed25519Keyring are required, using AccountKeyring bring confusion. There are two AccountKeyring definitions, it becomes more complex if export two AccountKeyring from frame.

Request

remove all AccountKeyring, re-export Sr25519Keyring and Ed25519Keyring from frame so that don't need extra use sp-keyring

Solution

No response

Are you willing to help with this request?

Yes!

@programskillforverification programskillforverification added the I5-enhancement An additional feature request. label Sep 27, 2024
@bkontur
Copy link
Contributor

bkontur commented Sep 27, 2024

Do you plan to do it as a part of #5804?

@programskillforverification
Copy link
Contributor Author

Do you plan to do it as a part of #5804?

Yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I5-enhancement An additional feature request.
Projects
None yet
Development

No branches or pull requests

2 participants