We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/paritytech/polkadot-sdk/blob/master/substrate/primitives/keyring/src/lib.rs#L34 Compared with AccountKeyring, Sr25519Keyring and Ed25519Keyring are more intuitive. When both Sr25519Keyring and Ed25519Keyring are required, using AccountKeyring bring confusion. There are two AccountKeyring definitions, it becomes more complex if export two AccountKeyring from frame.
AccountKeyring
Sr25519Keyring
Ed25519Keyring
remove all AccountKeyring, re-export Sr25519Keyring and Ed25519Keyring from frame so that don't need extra use sp-keyring
frame
sp-keyring
No response
Yes!
The text was updated successfully, but these errors were encountered:
Do you plan to do it as a part of #5804?
Sorry, something went wrong.
Yes.
No branches or pull requests
Is there an existing issue?
Experiencing problems? Have you tried our Stack Exchange first?
Motivation
https://github.com/paritytech/polkadot-sdk/blob/master/substrate/primitives/keyring/src/lib.rs#L34
Compared with
AccountKeyring
,Sr25519Keyring
andEd25519Keyring
are more intuitive.When both
Sr25519Keyring
andEd25519Keyring
are required, usingAccountKeyring
bring confusion. There are twoAccountKeyring
definitions, it becomes more complex if export twoAccountKeyring
from frame.Request
remove all
AccountKeyring
, re-exportSr25519Keyring
andEd25519Keyring
fromframe
so that don't need extra usesp-keyring
Solution
No response
Are you willing to help with this request?
Yes!
The text was updated successfully, but these errors were encountered: