Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block gap assumes there is a warp sync even when there isn't any #4607

Open
2 tasks done
nazar-pc opened this issue May 28, 2024 · 2 comments
Open
2 tasks done

Block gap assumes there is a warp sync even when there isn't any #4607

nazar-pc opened this issue May 28, 2024 · 2 comments
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.

Comments

@nazar-pc
Copy link
Contributor

Is there an existing issue?

  • I have searched the existing issues

Experiencing problems? Have you tried our Stack Exchange first?

  • This is not a support question.

Description of bug

When node starts and there is a block gap, warp sync phase is set to DownloadingBlocks:

let warp_sync_progress = self.gap_sync.as_ref().map(|gap_sync| WarpSyncProgress {
phase: WarpSyncPhase::DownloadingBlocks(gap_sync.best_queued_number),
total_bytes: 0,
});

The funny thing is, this happens even if there is no warp sync params configured, meaning warp sync is not present/possible at all.

Steps to reproduce

Happens after inserting a block with higher number using apply_block and restarting node afterwards

@nazar-pc nazar-pc added I10-unconfirmed Issue might be valid, but it's not yet known. I2-bug The node fails to follow expected behavior. labels May 28, 2024
@bkchr bkchr added this to Networking May 28, 2024
@bkchr
Copy link
Member

bkchr commented May 28, 2024

When node starts and there is a block gap

Not wanting to say that the current behavior is correct, but why do you have a gap?

@nazar-pc
Copy link
Contributor Author

Due to custom sync mechanism, see #4407

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I2-bug The node fails to follow expected behavior. I10-unconfirmed Issue might be valid, but it's not yet known.
Projects
Status: No status
Development

No branches or pull requests

2 participants