Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid extra checks in transaction refund extension #2820

Open
svyatonik opened this issue Feb 5, 2024 · 0 comments
Open

Avoid extra checks in transaction refund extension #2820

svyatonik opened this issue Feb 5, 2024 · 0 comments
Labels
A-chores Something that has to be done, as part of regular maintenance
Milestone
Nice To Have

Comments

@svyatonik
Copy link
Contributor

Once paritytech/polkadot-sdk#2280 is merged, we could use the TransactionExtension::Val to pass data from fn validate() to fn prepare() as it is done here: paritytech/polkadot-sdk@d8ed66d#diff-7972c739dd1acb1e23b641b2a26a7b36df883553662a186ab930295ffbee9005R481. It'd simplify code a bit - we won't need to perform the same checks twice.

(I don't want to do that in initial PR, because it adds 8K lines and I want better review for this ^^^ change
@svyatonik svyatonik added the A-chores Something that has to be done, as part of regular maintenance label Feb 5, 2024
@svyatonik svyatonik added this to the Nice To Have milestone Feb 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-chores Something that has to be done, as part of regular maintenance
Projects
None yet
Milestone
Nice To Have
Development

No branches or pull requests
1 participant
@svyatonik