Skip to content

Commit 54a8e06

Browse files
authored
tests/substrate: Remove outdated substrate specific conformace testing (#370)
The substrate/conformance testing was hidden behind a `custom_sc_network` feature flag. However, the code relied on the `custom-sc-network` feature flag (`-` instead of `_`). Because this feature never existed, the tests quickly became out of date. Furthermore, upon inspection many internal structures exposed by `sc-network` were either removed or made private. Instead, they should live in substrate and are effectively replaced by: - paritytech/polkadot-sdk#7361 - paritytech/polkadot-sdk#7484 Closes: #353 cc @paritytech/networking --------- Signed-off-by: Alexandru Vasile <[email protected]>
1 parent efdfa13 commit 54a8e06

File tree

10 files changed

+229
-5768
lines changed

10 files changed

+229
-5768
lines changed

Cargo.lock

Lines changed: 228 additions & 4432 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,6 @@ ring = { version = "0.16.20", optional = true }
5858
webpki = { version = "0.22.4", optional = true }
5959

6060
[dev-dependencies]
61-
asynchronous-codec = "0.7.0"
6261
libp2p = { version = "0.51.4", features = [
6362
"tokio",
6463
"dns",
@@ -74,15 +73,11 @@ libp2p = { version = "0.51.4", features = [
7473
"quic",
7574
]}
7675
quickcheck = "1.0.3"
77-
rand_xorshift = "0.3.0"
78-
sc-network = "0.48.1"
79-
sc-utils = "17.0.0"
8076
serde_json = "1.0.122"
8177
tracing-subscriber = { version = "0.3.16", features = ["env-filter"] }
8278
futures_ringbuf = "0.4.0"
8379

8480
[features]
85-
custom_sc_network = []
8681
quic = ["dep:webpki", "dep:quinn", "dep:rustls", "dep:ring"]
8782
webrtc = ["dep:str0m"]
8883
websocket = ["dep:tokio-tungstenite"]

tests/conformance/mod.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,5 +20,3 @@
2020

2121
#[cfg(test)]
2222
mod rust;
23-
#[cfg(test)]
24-
mod substrate;

tests/conformance/substrate/connection.rs

Lines changed: 0 additions & 150 deletions
This file was deleted.

tests/conformance/substrate/mod.rs

Lines changed: 0 additions & 30 deletions
This file was deleted.

0 commit comments

Comments
 (0)