Skip to content

TLS support for the HTTP client #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
abustany opened this issue May 21, 2019 · 2 comments
Closed

TLS support for the HTTP client #433

abustany opened this issue May 21, 2019 · 2 comments
Labels
feat

Comments

@abustany
Copy link
Contributor

Use hyper-tls to allow connecting a client over HTTPS. #431 is probably relevant here too, to avoid pulling hyper-tls unconditionally.
@ascjones ascjones added the feat label May 21, 2019
@ascjones
Copy link
Contributor

e.g. https://github.com/tomusdrw/rust-web3/blob/master/src/transports/http.rs#L97

tomusdrw pushed a commit that referenced this issue May 23, 2019
@abustany @tomusdrw
Optional TLS support for HTTP transport (#433) (#435)
ff4e20e 
* Optional TLS support for HTTP transport (#433)

* Reorganize CI build matrix with exclusion rules

This allows adding other dimensions to the matrix without having to
explicitly specify all combinations in the inclusion list.

* Add jsonrpc-core-client features to the build matrix

* Fix multiple publishing of documentation in CI

The after_success step will get executed for each successful row in the
build matrix, and the condition in the script would match for several
rows after the addition of the tls feature in the previous commit.
@dvc94ch
Copy link
Contributor

dvc94ch commented May 25, 2019

Closed by #435

@dvc94ch dvc94ch closed this as completed May 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feat
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ascjones @dvc94ch @abustany