Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Foundry-compilers][Revive integration] Simplify and reintegrate previously implemented support for revive #14

Open
pkhry opened this issue Feb 19, 2025 · 0 comments
Assignees

Comments

@pkhry
Copy link
Collaborator

pkhry commented Feb 19, 2025

Main issue is the fact that code in the initial implementation duplicates the main implementations(ie Project, ProjectCompiler, etc) word for word to call resolc directly instead of reusing the implementation that's already present.

Also it doesn't use or implement any integration tests and makes upkeep rather difficult.

see initial implementation

@pkhry pkhry self-assigned this Feb 19, 2025
@smiasojed smiasojed added this to the Basic features milestone Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants