Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigating from notifications does not load the extension. #13

Open
parasharrajat opened this issue Aug 22, 2022 · 0 comments
Open

Navigating from notifications does not load the extension. #13

parasharrajat opened this issue Aug 22, 2022 · 0 comments
Labels
bug Something isn't working

Comments

@parasharrajat
Copy link
Owner

Possibly because, of page, the load is never fired in such cased and thus contentscripts are failed to load by the browser. The browser depends on page load...

Possible Solution

  1. Dynamically inject the scripts when tab URL changes. it could be hectic to do as we will have to listen for all URL changes on all the tabs but seems like the optimized solution.
  2. inject the content scripts on all of the GitHub pages but hide the UI until the URL matches the correct path. The problem with this is that extra extension UI is injected for all pages of GitHub.
@parasharrajat parasharrajat added the bug Something isn't working label Sep 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant