Improve bit editing alt #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* bit:hover- experimenting with more minimal hover state to fit design, with diff color gradients for bit types * bit:hover:text- only show resize during hover
* adding noselect on map
… of a crowded canvas * bit:text:create- min width/height
…keDraggable has no trigger now * bit:text:drag- excluding resize handle from drag * bit:text- hide triangle resize icon by default again * bit:text- double click to edit text, autosave on hover exit * bit:drag- moving hover scale animations to onPress + onRelease * map: dble click to create a bit. Goes directly into editing * refactor: separate out text and sketch EditingIds to independent sessions vars
* refactor: $bitElement names * bit:edit- via double click fixed * bit:edit- via key command- commented for now * bug: not allowing bit:edit if already editing
* bug: bit:edit: fixed bad reference to canvas.id * bug: bit:text:edit- Draggable disable needs to be before resizable set. Resizable init was wrong. * bit:text:edit- resize handle flush to corner
* bit:text:edit- delete UI button * bit:text:edit- save UI button
…r) vs edit (shown once editing) * bit:text:edit- experimenting with turning off autoscroll, scroll within a scroll doesnt feel right * bit:image- adding delete UI icon * activity stream: adding header icon, iterating design towards an off canvas menu * bit:text:edit- bug:fixed resizing on edits, after first save
* bug: fixed missing param * bit:text:edit- cancel button bypassing save correctly
* bit--hover: moved icons to centered position: aiming for buttons on edges results in often overshooting mouse
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@angelcabo : Building on your
improve-bit-editingbranch: Lots of refactoring, added UI buttons. : defaulting to drag for bits, and requiring a person to go into text edit mode.Both are promising improvements to text editing, each has its pros + cons.
this branch (alt): demo PR 20
pros:
cons:
your original branch : demo PR 19
pros:
cons:
Outstanding todo's: https://trello.com/c/AAwflsK7/353-bit-edit-text-2nd-pass