Skip to content

Split in tss-esapi and tss-esapi-sys #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ionut-arm opened this issue Jan 15, 2020 · 4 comments · Fixed by #177
Closed

Split in tss-esapi and tss-esapi-sys #30

ionut-arm opened this issue Jan 15, 2020 · 4 comments · Fixed by #177
Labels
enhancement New feature or request
Milestone

Comments

@ionut-arm
Copy link
Member

ionut-arm commented Jan 15, 2020

Builds are broken for generating the docs for publishing on docs.rs due to the TSS libraries not being installed on the Docker image where the build takes place. Unfortunately there seems to be no quick way to fix this (e.g. by installing a system package).

The proposed solution is to set up dynamic loading through libloading . This implies creating a new type of FFI binding which can only be hand-crafted, as bindgen does not currently support it (see rust-lang/rust-bindgen#1541 ).

Alternatively, the work for adding the support in bindgen for this case could be done.
Or, the TSS include files can be pulled as a submodule.

EDIT: Initial problem was fixed by adding static bindings ESAPI that are used only for creating documentation. Thus, an issue still exists around removing said bindings and one of the suggestions above should be used.

@ionut-arm ionut-arm added the enhancement New feature or request label Jan 15, 2020
@ionut-arm ionut-arm added this to the Rust tss-esapi v1.0 milestone Jan 15, 2020
@ionut-arm ionut-arm changed the title Fix docs.rs builds Enable docs.rs build in an elegant way Feb 27, 2020
@hug-dev
Copy link
Member

hug-dev commented Jun 2, 2020

That would be solved by implementing the -sys approach: split the repo into a tss-esapi and tss-esapi-sys crates, with the tss-esapi-sys compiling from the source if the libraries are not installed on the system 😃

@hug-dev hug-dev changed the title Enable docs.rs build in an elegant way Split in tss-esapi and tss-esapi-sys Jun 2, 2020
@ionut-arm
Copy link
Member Author

@joechrisellis 's PR for bindgen ( rust-lang/rust-bindgen#1846 ) will come in handy, as we can now rely on bindgen for dynamic loading.

@ionut-arm
Copy link
Member Author

#75 is a duplicate of this, closing that one - whenever this gets picked up, please review the comments there too!

@ionut-arm
Copy link
Member Author

#85 is also quite relevant - if anything, they should be done together

@hug-dev hug-dev mentioned this issue Nov 11, 2020
4 tasks
@puiterwijk puiterwijk linked a pull request Jan 26, 2021 that will close this issue
tgonzalezorlandoarm pushed a commit to tgonzalezorlandoarm/rust-tss-esapi that referenced this issue Mar 14, 2024
Use thread pool instead of new thread per request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants