-
Notifications
You must be signed in to change notification settings - Fork 56
Split in tss-esapi and tss-esapi-sys #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
That would be solved by implementing the |
@joechrisellis 's PR for bindgen ( rust-lang/rust-bindgen#1846 ) will come in handy, as we can now rely on bindgen for dynamic loading. |
#75 is a duplicate of this, closing that one - whenever this gets picked up, please review the comments there too! |
#85 is also quite relevant - if anything, they should be done together |
Use thread pool instead of new thread per request
Builds are broken for generating the docs for publishing on docs.rs due to the TSS libraries not being installed on the Docker image where the build takes place. Unfortunately there seems to be no quick way to fix this (e.g. by installing a system package).The proposed solution is to set up dynamic loading through
libloading
. This implies creating a new type of FFI binding which can only be hand-crafted, asbindgen
does not currently support it (see rust-lang/rust-bindgen#1541 ).Alternatively, the work for adding the support in bindgen for this case could be done.
Or, the TSS include files can be pulled as a submodule.
EDIT: Initial problem was fixed by adding static bindings ESAPI that are used only for creating documentation. Thus, an issue still exists around removing said bindings and one of the suggestions above should be used.
The text was updated successfully, but these errors were encountered: