Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add namespacing for Core and PSA structures #35

Open
hug-dev opened this issue Mar 19, 2020 · 1 comment
Open

Add namespacing for Core and PSA structures #35

hug-dev opened this issue Mar 19, 2020 · 1 comment
Labels
enhancement New feature or request large Effort label

Comments

@hug-dev
Copy link
Member

hug-dev commented Mar 19, 2020

With #30 in, there is a clear separation of Core and PSA structures with the Psa or psa_ prefix added everywhere.
A better idiomatic and scalable way at separating them would be to use namespacing.

In the operations, the Core and PSA files would be in their own folders.
In the interface, Core and PSA structures would be in their own module. There would be enumerations of PSA operation opcodes and Core operation opcodes with an Opcode enum of those enum at the top. Same for the ResponseStatus.

The Provide trait contains Core and PSA operations. One option could be to have two Provide traits: PsaProvide and CoreProvide.

This issue is mainly for discussion on those topics.

@hug-dev hug-dev added the enhancement New feature or request label Mar 19, 2020
@ionut-arm
Copy link
Member

It's worth considering if we want to go the "Mbed Crypto SE driver" way of having traits for different types of crypto operations - e.g. PsaAsymSign

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request large Effort label
Projects
None yet
Development

No branches or pull requests

2 participants