Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redundant assertion in Base64Test #27

Open
TimWolla opened this issue Nov 9, 2020 · 0 comments
Open

Redundant assertion in Base64Test #27

TimWolla opened this issue Nov 9, 2020 · 0 comments

Comments

@TimWolla
Copy link
Contributor

TimWolla commented Nov 9, 2020

$this->assertSame(
$random,
Base64::decode($unpadded)
);
$this->assertSame(
$random,
Base64::decode($unpadded)
);

Should one of these test against encodeUnpadded like for Base32:

$this->assertSame(
$unpadded,
Base32::encodeUnpadded($random)
);
?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant