Error in >=4.3.0 when setPermitEmpty option is used.

[stevenmaguire]

Version 4.3.0 introduced some new logic using the is_scalar method. It appears the new logic is meant to enforce some constraints on the value. Unfortunately, when the setPermitEmpty functionality it is possible for the value of $row[$field] to be null. Because is_scalar(null) evaluates to false, this new logic is being engaged when perhaps it shouldn't be.

ciphersweet/src/EncryptedRow.php

Lines 532 to 534 in ccb2e1d

	if (!is_scalar($row[$field])) {
	throw new TypeError('Invalid type for ' . $field);
	}

Perhaps this was an oversight?

[paragonie-security]

Check v4.5.0 which fixed this error.

[stevenmaguire]

I had read that version 4.5.0 addressed this issue, however it was still present when targeting that specific version. When digging deeper, it appears that the issue was ultimately coming from a framework specific behavior that changed the incoming fields in the encrypted row, which was then triggering this error. Thanks for following up.

[yormy]

I too can confirm that this is still an issue in 4.5.0

According to php docs:
is_scalar() does not consider NULL to be scalar.

[paragonie-security]

According to php docs: is_scalar() does not consider NULL to be scalar.

This is a red herring.

ciphersweet/src/EncryptedRow.php

Lines 613 to 631 in 575dda1

	// Support nullable types
	if (in_array($type, Constants::TYPES_OPTIONAL, true)) {
	if (is_null($row[$field])) {
	continue;
	}
	}
	// Boolean always supported NULL as a value to encrypt
	if (in_array($type, Constants::TYPES_BOOLEAN, true) && is_null($row[$field])) {
	$plaintext = $this->convertToString($row[$field], Constants::TYPE_BOOLEAN);
	$return[$field] = $backend->encrypt($plaintext, $key, $aad);
	continue;
	}
	// All others must be scalar
	if (!is_scalar($row[$field])) {
	// NULL is not permitted.
	throw new TypeError('Invalid type for ' . $field);
	}

Look again:

ciphersweet/src/EncryptedRow.php

Lines 613 to 618 in 575dda1

	// Support nullable types
	if (in_array($type, Constants::TYPES_OPTIONAL, true)) {
	if (is_null($row[$field])) {
	continue;
	}
	}

You need to declare your types optional. This is a new feature. See #92

[paragonie-security]

I've released v4.5.1 which adds a more helpful exception message when NULL is encountered but the support for NULL is not declared in configuration.