Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

primitives: use alloy BlockWithParent #12606

Open
Tracked by #12576
tcoratger opened this issue Nov 16, 2024 · 0 comments
Open
Tracked by #12576

primitives: use alloy BlockWithParent #12606

tcoratger opened this issue Nov 16, 2024 · 0 comments
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain

Comments

@tcoratger
Copy link
Contributor

Describe the feature

Now that alloy-rs/alloy#1650 has been merged, after the next release of alloy, we will be able to use directly the BlockWithParent alloy type and remove the redundant definition from reth here

/// A helper struct to store the block number/hash and its parent hash.
#[derive(Debug, Clone, PartialEq, Eq, Hash, Serialize, Deserialize)]
pub struct BlockWithParent {
/// Parent hash.
pub parent: B256,
/// Block number/hash.
pub block: BlockNumHash,
}

Additional context

No response

@tcoratger tcoratger added C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Nov 16, 2024
@emhane emhane added C-debt Refactor of code section that is hard to understand or maintain A-sdk Related to reth's use as a library and removed C-enhancement New feature or request S-needs-triage This issue needs to be labelled labels Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-sdk Related to reth's use as a library C-debt Refactor of code section that is hard to understand or maintain
Projects
Status: Todo
Development

No branches or pull requests

2 participants