add empty chunk handling, importing python crate dependencies, tx filtering by address, support for new datatypes in python crate #147
Conversation
davidthegardens
changed the title
davidthegardens
changed the title
| let addr_filter: Box<dyn Fn(&Transaction) -> bool + Send> = | ||
| if let Some(address) = &request.address { | ||
| Box::new(move |tx| { | ||
| let mut transactions_set = TRANSACTIONS_SET.lock().unwrap(); |
There was a problem hiding this comment.
what is the reason for using TRANSACTIONS_SET here?
There was a problem hiding this comment.
In cases where you prompt 2 or more addresses, anytime both the sender and receiver of the transaction are in --addresses, you will get duplicated transactions in the df. Originally, I used TRANSACTIONS_SET to prevent duplicates.
I've since made things more efficient and avoided global variables by making the list of addresses accessible.
This is how it works now:
from_bool = addresses.contains(from_address)
to_bool = addresses.contains(to_address)
if from_bool and to_bool:
return from_address==current_address
else:
return from_address==current_address or to_address==current_address
I'm unsure if the way I'm getting the list of addresses is the best way, but I couldn't figure out how else to do it. Currently, it gets the addresses by parsing 'cli_command' from ExecutionEnv.
There was a problem hiding this comment.
nice, looking very clean now
additionally I think the request.addresses() will give the relevant info without need for get_addresses(). no need to parse cli arg data, request.addresses() will give you the list of addresses relevant to the current chunk (which might be different from all of the addresses, if youre chunking by address)
There was a problem hiding this comment.
Thanks! I can't seem to find .addresses(), in request. There is .address though, which only has one address :/
Since cryo filters transactions by each address separately, I'd need the complete list of addresses in addition to the address for the current chunk to prevent duplicates.
| let addr_filter: Box<dyn Fn(&Transaction) -> bool + Send> = | ||
| if let Some(address) = &request.address { | ||
| Box::new(move |tx| { | ||
| let mut transactions_set = TRANSACTIONS_SET.lock().unwrap(); |
There was a problem hiding this comment.
nice, looking very clean now
additionally I think the request.addresses() will give the relevant info without need for get_addresses(). no need to parse cli arg data, request.addresses() will give you the list of addresses relevant to the current chunk (which might be different from all of the addresses, if youre chunking by address)
|
heyo. everything is looking great on the pr. the last thing is get_addresses(). does request.addresses() have everything you need to avoid the get_addresses() function? |
Hey, thank you! So request.addresses() doesn't seem to exist and request.address doesn't have all the information needed unfortunately. |
Motivation
Solution
PR Checklist