We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Goodness knows why I have not noticed this before. Take this commit on finalization from the editor:
papyri/idp.data@544c6a9
Looking at lines 2, 34-43 one can see how https://... has been changed to http://... That should not be happening, because we want https:// throughout (Hugh carried out a massive global change https://github.com/papyri/idp.data/blob/master/DDB_EpiDoc_XML/bgu/bgu.4/bgu.4.1059.xml#L2 not so long ago: papyri/idp.data@63dcc31).
https://...
http://...
https://
So I think a tweak to the SoSOL code is required.
An aside: look at https://github.com/papyri/idp.data/blob/master/DDB_EpiDoc_XML/bgu/bgu.4/bgu.4.1059.xml#L2:
<?xml-model href="https://epidoc.stoa.org/schema/8.16/tei-epidoc.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>
That does not make sense to me if I look at papyri/idp.data@544c6a9
- <?xml-model href="https://epidoc.stoa.org/schema/8.16/tei-epidoc.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?> + <?xml-model href="http://www.stoa.org/epidoc/schema/8.16/tei-epidoc.rng" type="application/xml" schematypens="http://relaxng.org/ns/structure/1.0"?>
There, a rule seems to be overriding (correctly !! because https:// remains) the commit report.
The text was updated successfully, but these errors were encountered:
ryanfb
No branches or pull requests
Goodness knows why I have not noticed this before. Take this commit on finalization from the editor:
papyri/idp.data@544c6a9
Looking at lines 2, 34-43 one can see how
https://...
has been changed tohttp://...
That should not be happening, because we wanthttps://
throughout (Hugh carried out a massive global change https://github.com/papyri/idp.data/blob/master/DDB_EpiDoc_XML/bgu/bgu.4/bgu.4.1059.xml#L2 not so long ago: papyri/idp.data@63dcc31).So I think a tweak to the SoSOL code is required.
An aside: look at https://github.com/papyri/idp.data/blob/master/DDB_EpiDoc_XML/bgu/bgu.4/bgu.4.1059.xml#L2:
That does not make sense to me if I look at papyri/idp.data@544c6a9
There, a rule seems to be overriding (correctly !! because
https://
remains) the commit report.The text was updated successfully, but these errors were encountered: