Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a new PR if a previous release PR exists but has been closed #19

Open
pwtyler opened this issue Jun 6, 2023 · 2 comments
Open
Labels
enhancement New feature or request release-pr Issue is related to the release-pr action

Comments

@pwtyler
Copy link
Member

pwtyler commented Jun 6, 2023

Currently, when "Release PR" runs, it checks if a PR exists and otherwise skips the creation step. We should create a new PR if a release PR has been created but then closed.

@pwtyler pwtyler changed the title Create a new PR if a previous release PR has been previously closed Create a new PR if a previous release PR has been closed Jun 6, 2023
@jazzsequence
Copy link
Contributor

what are the use cases of this? when would we want a new release PR and not just rebase the PR from the base branch?

@pwtyler
Copy link
Member Author

pwtyler commented Jul 5, 2023

The case here is if a pre-release PR was created and then closed. It is my current thought that a new PR should be created, but it could be argued that the existing PR should be re-opened.

@pwtyler pwtyler changed the title Create a new PR if a previous release PR has been closed Create a new PR if a previous release PR exists but has been closed Dec 22, 2023
@pwtyler pwtyler transferred this issue from pantheon-systems/plugin-pipeline-example Dec 22, 2023
@pwtyler pwtyler added enhancement New feature or request release-pr Issue is related to the release-pr action labels Dec 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request release-pr Issue is related to the release-pr action
Projects
None yet
Development

No branches or pull requests

2 participants