Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address initial feedback #26

Open
7 tasks
pwtyler opened this issue Dec 20, 2024 · 0 comments
Open
7 tasks

Address initial feedback #26

pwtyler opened this issue Dec 20, 2024 · 0 comments

Comments

@pwtyler
Copy link
Member

pwtyler commented Dec 20, 2024

Got some initial feedback on the action a while back when Kevin initially spun up the project. To review and act on individually.

  • action.yml: I'd recommend not setting a default for the test-versions, but to default to the same behaviour as PHPCompatibility has natively (second bullet in https://github.com/PHPCompatibility/PHPCompatibility#sniffing-your-code-for-compatibility-with-specific-php-versions)
  • Sniffing for 8.0- while using PHPCompatibility 9.3 is kind of useless as 9.3 doesn't really contain any PHP 8 checks yet.
  • entrypoint.sh: Composer install is not being cached
  • Q: how does the composer install play with project native composer installs ?
  • composer.json: please don't declare PHPCS as requirement, but let PHPCompatibility and the Composer PHPCS plugin handle that.
  • Heads-up: as of PHPCompat 10.0, the Composer PHPCS plugin will be a dependency of PHPCompatibility, so no need to require it anymore. (you do still need to allow the plugin)
  • Committed composer.lock: this could potentially be problematic if the setup PHP step is being skipped and the PHP version on which the composer install is being run does not match a supported version. Chances are slim as all three dependencies still support PHP 5.4, but still.

PHPCompatibility/PHPCompatibility#1414 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant