Update usage of passthru in Quicksilver to check return_var

[marfillaster]

Re: Database Workflow Tool, Fix Broken Links in WordPress

Priority: Medium

Issue Description:

The passthru usage for fixing broken links will result in a false positive if wp cli returns with non-zero exit code.

Suggested Resolution:

Check &$return_var value and raise an error to propagate the error to the calling quicksilver script.

$cmd = 'wp search-replace "://test-example.pantheonsite.io" "://example.com" --all-tables ';
passthru($cmd . ' 2>&1', $exit);
if (0 !== $exit) {
  trigger_error(sprintf('Command "%s" exit status: %s', $cmd, $exit), E_USER_ERROR);
}

[marfillaster]

Also created issue on pantheon-systems/quicksilver-examples/issues/169

[alexfornuto]

CC @pantheon-systems/devrel

[alexfornuto]

Moving to not ready until the discussion in pantheon-systems/quicksilver-examples#169 creates a resolution we can duplicate.

[EdwardAngert]

closing as stale until pantheon-systems/quicksilver-examples#169 is resolved