From ecf2a054bd314354decbbcac8f5b0a3c00fee5df Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 17:22:45 +0000 Subject: [PATCH 01/17] isna decorator with set_module('pandas') --- pandas/core/dtypes/missing.py | 1 + pandas/tests/api/test_api.py | 1 + 2 files changed, 2 insertions(+) diff --git a/pandas/core/dtypes/missing.py b/pandas/core/dtypes/missing.py index b9cd6ae2f13e8..32e745e1b0312 100644 --- a/pandas/core/dtypes/missing.py +++ b/pandas/core/dtypes/missing.py @@ -93,6 +93,7 @@ def isna( def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: ... +@set_module('pandas') def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: """ Detect missing values for an array-like object. diff --git a/pandas/tests/api/test_api.py b/pandas/tests/api/test_api.py index 842fa1a151267..da020652c3976 100644 --- a/pandas/tests/api/test_api.py +++ b/pandas/tests/api/test_api.py @@ -416,3 +416,4 @@ def test_set_module(): assert pd.Period.__module__ == "pandas" assert pd.Timestamp.__module__ == "pandas" assert pd.Timedelta.__module__ == "pandas" + assert pd.isna.__module__ == "pandas" From 3a42f578b5b9252542006a2695957aaac374f5bd Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 17:24:52 +0000 Subject: [PATCH 02/17] decorator to isna --- pandas/core/dtypes/missing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/dtypes/missing.py b/pandas/core/dtypes/missing.py index 32e745e1b0312..8ff82805f60ec 100644 --- a/pandas/core/dtypes/missing.py +++ b/pandas/core/dtypes/missing.py @@ -93,7 +93,7 @@ def isna( def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: ... -@set_module('pandas') +@set_module("pandas") def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: """ Detect missing values for an array-like object. From 63841f6f57c38d811aef007634bd73e9bbb93f85 Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 17:26:01 +0000 Subject: [PATCH 03/17] test_change --- pandas/tests/api/test_api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/api/test_api.py b/pandas/tests/api/test_api.py index da020652c3976..ef77ef41b8b6c 100644 --- a/pandas/tests/api/test_api.py +++ b/pandas/tests/api/test_api.py @@ -416,4 +416,4 @@ def test_set_module(): assert pd.Period.__module__ == "pandas" assert pd.Timestamp.__module__ == "pandas" assert pd.Timedelta.__module__ == "pandas" - assert pd.isna.__module__ == "pandas" + From b020930f9b8a4eaf730ae1166f0d503cce754147 Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 17:29:40 +0000 Subject: [PATCH 04/17] decorator on isna --- pandas/tests/api/test_api.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/tests/api/test_api.py b/pandas/tests/api/test_api.py index ef77ef41b8b6c..da020652c3976 100644 --- a/pandas/tests/api/test_api.py +++ b/pandas/tests/api/test_api.py @@ -416,4 +416,4 @@ def test_set_module(): assert pd.Period.__module__ == "pandas" assert pd.Timestamp.__module__ == "pandas" assert pd.Timedelta.__module__ == "pandas" - + assert pd.isna.__module__ == "pandas" From 7b0df0863eb6f86a9bd574aeb0da29337d1e2055 Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 17:31:46 +0000 Subject: [PATCH 05/17] test_commit --- pandas/core/dtypes/missing.py | 2 +- pandas/tests/api/test_api.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pandas/core/dtypes/missing.py b/pandas/core/dtypes/missing.py index 8ff82805f60ec..e7fc3ddfb3017 100644 --- a/pandas/core/dtypes/missing.py +++ b/pandas/core/dtypes/missing.py @@ -93,7 +93,7 @@ def isna( def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: ... -@set_module("pandas") +# @set_module("pandas") def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: """ Detect missing values for an array-like object. diff --git a/pandas/tests/api/test_api.py b/pandas/tests/api/test_api.py index da020652c3976..1b62c845085b7 100644 --- a/pandas/tests/api/test_api.py +++ b/pandas/tests/api/test_api.py @@ -416,4 +416,4 @@ def test_set_module(): assert pd.Period.__module__ == "pandas" assert pd.Timestamp.__module__ == "pandas" assert pd.Timedelta.__module__ == "pandas" - assert pd.isna.__module__ == "pandas" + # assert pd.isna.__module__ == "pandas" From d01c55a2a08b85065438d847cbaf094b0313ee38 Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 17:33:05 +0000 Subject: [PATCH 06/17] decorator --- pandas/core/dtypes/missing.py | 2 +- pandas/tests/api/test_api.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pandas/core/dtypes/missing.py b/pandas/core/dtypes/missing.py index e7fc3ddfb3017..8ff82805f60ec 100644 --- a/pandas/core/dtypes/missing.py +++ b/pandas/core/dtypes/missing.py @@ -93,7 +93,7 @@ def isna( def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: ... -# @set_module("pandas") +@set_module("pandas") def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: """ Detect missing values for an array-like object. diff --git a/pandas/tests/api/test_api.py b/pandas/tests/api/test_api.py index 1b62c845085b7..da020652c3976 100644 --- a/pandas/tests/api/test_api.py +++ b/pandas/tests/api/test_api.py @@ -416,4 +416,4 @@ def test_set_module(): assert pd.Period.__module__ == "pandas" assert pd.Timestamp.__module__ == "pandas" assert pd.Timedelta.__module__ == "pandas" - # assert pd.isna.__module__ == "pandas" + assert pd.isna.__module__ == "pandas" From b3ea24922f47c200fd601c63f993fd3198079460 Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 17:38:13 +0000 Subject: [PATCH 07/17] testing --- pandas/core/dtypes/missing.py | 2 +- pandas/tests/api/test_api.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pandas/core/dtypes/missing.py b/pandas/core/dtypes/missing.py index 8ff82805f60ec..e7fc3ddfb3017 100644 --- a/pandas/core/dtypes/missing.py +++ b/pandas/core/dtypes/missing.py @@ -93,7 +93,7 @@ def isna( def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: ... -@set_module("pandas") +# @set_module("pandas") def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: """ Detect missing values for an array-like object. diff --git a/pandas/tests/api/test_api.py b/pandas/tests/api/test_api.py index da020652c3976..1b62c845085b7 100644 --- a/pandas/tests/api/test_api.py +++ b/pandas/tests/api/test_api.py @@ -416,4 +416,4 @@ def test_set_module(): assert pd.Period.__module__ == "pandas" assert pd.Timestamp.__module__ == "pandas" assert pd.Timedelta.__module__ == "pandas" - assert pd.isna.__module__ == "pandas" + # assert pd.isna.__module__ == "pandas" From 2cb18b1881c17d95d60d923d561b80a4a3ee870f Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 17:39:07 +0000 Subject: [PATCH 08/17] isna decorator --- pandas/core/dtypes/missing.py | 2 +- pandas/tests/api/test_api.py | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/pandas/core/dtypes/missing.py b/pandas/core/dtypes/missing.py index e7fc3ddfb3017..8ff82805f60ec 100644 --- a/pandas/core/dtypes/missing.py +++ b/pandas/core/dtypes/missing.py @@ -93,7 +93,7 @@ def isna( def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: ... -# @set_module("pandas") +@set_module("pandas") def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: """ Detect missing values for an array-like object. diff --git a/pandas/tests/api/test_api.py b/pandas/tests/api/test_api.py index 1b62c845085b7..da020652c3976 100644 --- a/pandas/tests/api/test_api.py +++ b/pandas/tests/api/test_api.py @@ -416,4 +416,4 @@ def test_set_module(): assert pd.Period.__module__ == "pandas" assert pd.Timestamp.__module__ == "pandas" assert pd.Timedelta.__module__ == "pandas" - # assert pd.isna.__module__ == "pandas" + assert pd.isna.__module__ == "pandas" From d4dba0e1ddeb03e9c05709eddd31c904d1819eaf Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 17:42:24 +0000 Subject: [PATCH 09/17] test --- pandas/core/dtypes/missing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/dtypes/missing.py b/pandas/core/dtypes/missing.py index 8ff82805f60ec..e7fc3ddfb3017 100644 --- a/pandas/core/dtypes/missing.py +++ b/pandas/core/dtypes/missing.py @@ -93,7 +93,7 @@ def isna( def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: ... -@set_module("pandas") +# @set_module("pandas") def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: """ Detect missing values for an array-like object. From 047f1dea81bf0de27514cbb374c0ff732d946c3e Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 17:43:19 +0000 Subject: [PATCH 10/17] decorator --- pandas/core/dtypes/missing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/dtypes/missing.py b/pandas/core/dtypes/missing.py index e7fc3ddfb3017..8ff82805f60ec 100644 --- a/pandas/core/dtypes/missing.py +++ b/pandas/core/dtypes/missing.py @@ -93,7 +93,7 @@ def isna( def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: ... -# @set_module("pandas") +@set_module("pandas") def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: """ Detect missing values for an array-like object. From 3b1fa65bbabc2f79bbb9ff9b26a706b7e58f09d3 Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 18:10:00 +0000 Subject: [PATCH 11/17] decorator_2 --- pandas/core/dtypes/missing.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/pandas/core/dtypes/missing.py b/pandas/core/dtypes/missing.py index 8ff82805f60ec..27dc762ac418d 100644 --- a/pandas/core/dtypes/missing.py +++ b/pandas/core/dtypes/missing.py @@ -43,6 +43,8 @@ ) from pandas.core.dtypes.inference import is_list_like +from pandas.util._decorators import set_module + if TYPE_CHECKING: from re import Pattern From 217a0ed7f1e04dd675d0887ead001cbf2e91d880 Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 19:17:19 +0000 Subject: [PATCH 12/17] detector_3 --- pandas/core/dtypes/missing.py | 5 ++++- pandas/tests/api/test_api.py | 1 + 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/pandas/core/dtypes/missing.py b/pandas/core/dtypes/missing.py index 27dc762ac418d..59f9a8af9c145 100644 --- a/pandas/core/dtypes/missing.py +++ b/pandas/core/dtypes/missing.py @@ -20,6 +20,8 @@ iNaT, ) +from pandas.util._decorators import set_module + from pandas.core.dtypes.common import ( DT64NS_DTYPE, TD64NS_DTYPE, @@ -43,7 +45,7 @@ ) from pandas.core.dtypes.inference import is_list_like -from pandas.util._decorators import set_module + if TYPE_CHECKING: from re import Pattern @@ -178,6 +180,7 @@ def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: isnull = isna +@set_module("pandas") def _isna(obj): """ Detect missing values, treating None, NaN or NA as null. diff --git a/pandas/tests/api/test_api.py b/pandas/tests/api/test_api.py index da020652c3976..a196b21802261 100644 --- a/pandas/tests/api/test_api.py +++ b/pandas/tests/api/test_api.py @@ -14,6 +14,7 @@ ) + class Base: def check(self, namespace, expected, ignored=None): # see which names are in the namespace, minus optional From f4007b4de12320f3e6aa84cefbb2e1016c4b43fa Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 19:26:44 +0000 Subject: [PATCH 13/17] decorator_4 --- pandas/core/dtypes/missing.py | 2 +- pandas/tests/api/test_api.py | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/pandas/core/dtypes/missing.py b/pandas/core/dtypes/missing.py index 59f9a8af9c145..ec3e67cb44c80 100644 --- a/pandas/core/dtypes/missing.py +++ b/pandas/core/dtypes/missing.py @@ -180,7 +180,6 @@ def isna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: isnull = isna -@set_module("pandas") def _isna(obj): """ Detect missing values, treating None, NaN or NA as null. @@ -313,6 +312,7 @@ def notna( def notna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: ... +@set_module('pandas') def notna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: """ Detect non-missing values for an array-like object. diff --git a/pandas/tests/api/test_api.py b/pandas/tests/api/test_api.py index a196b21802261..096601bf97152 100644 --- a/pandas/tests/api/test_api.py +++ b/pandas/tests/api/test_api.py @@ -418,3 +418,4 @@ def test_set_module(): assert pd.Timestamp.__module__ == "pandas" assert pd.Timedelta.__module__ == "pandas" assert pd.isna.__module__ == "pandas" + assert pd.notna.__module__ == "pandas" From 1db7799d143dc9329311c8f92db9b3f147d1874c Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 19:34:05 +0000 Subject: [PATCH 14/17] decorator_5 --- pandas/core/dtypes/missing.py | 2 -- pandas/tests/api/test_api.py | 1 - 2 files changed, 3 deletions(-) diff --git a/pandas/core/dtypes/missing.py b/pandas/core/dtypes/missing.py index ec3e67cb44c80..8c12ead5dd00d 100644 --- a/pandas/core/dtypes/missing.py +++ b/pandas/core/dtypes/missing.py @@ -45,8 +45,6 @@ ) from pandas.core.dtypes.inference import is_list_like - - if TYPE_CHECKING: from re import Pattern diff --git a/pandas/tests/api/test_api.py b/pandas/tests/api/test_api.py index 096601bf97152..62172f0e006e5 100644 --- a/pandas/tests/api/test_api.py +++ b/pandas/tests/api/test_api.py @@ -14,7 +14,6 @@ ) - class Base: def check(self, namespace, expected, ignored=None): # see which names are in the namespace, minus optional From cfea7856cc0319a188b37eb83a76974ba6c2822b Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 19:36:21 +0000 Subject: [PATCH 15/17] decorator_6 --- pandas/core/dtypes/missing.py | 1 - 1 file changed, 1 deletion(-) diff --git a/pandas/core/dtypes/missing.py b/pandas/core/dtypes/missing.py index 8c12ead5dd00d..6692b5d714ef9 100644 --- a/pandas/core/dtypes/missing.py +++ b/pandas/core/dtypes/missing.py @@ -21,7 +21,6 @@ ) from pandas.util._decorators import set_module - from pandas.core.dtypes.common import ( DT64NS_DTYPE, TD64NS_DTYPE, From 8be80a2d5e22c7f88455dd8e8fb6c455c0a4057d Mon Sep 17 00:00:00 2001 From: SiemBerhane <65135505+SiemBerhane@users.noreply.github.com> Date: Sat, 9 Nov 2024 19:47:06 +0000 Subject: [PATCH 16/17] detector_6 --- pandas/core/dtypes/missing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/dtypes/missing.py b/pandas/core/dtypes/missing.py index 6692b5d714ef9..c3ef34bc97588 100644 --- a/pandas/core/dtypes/missing.py +++ b/pandas/core/dtypes/missing.py @@ -309,7 +309,7 @@ def notna( def notna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: ... -@set_module('pandas') +@set_module("pandas") def notna(obj: object) -> bool | npt.NDArray[np.bool_] | NDFrame: """ Detect non-missing values for an array-like object. From 8c1e98f25cf80d8f4d8fd336261a464bb466cfe6 Mon Sep 17 00:00:00 2001 From: Simon Hawkins Date: Sat, 9 Nov 2024 19:59:33 +0000 Subject: [PATCH 17/17] lint --- pandas/core/dtypes/missing.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pandas/core/dtypes/missing.py b/pandas/core/dtypes/missing.py index c3ef34bc97588..f20ca44728664 100644 --- a/pandas/core/dtypes/missing.py +++ b/pandas/core/dtypes/missing.py @@ -19,8 +19,8 @@ NaT, iNaT, ) - from pandas.util._decorators import set_module + from pandas.core.dtypes.common import ( DT64NS_DTYPE, TD64NS_DTYPE,