DOC: pandas.DataFrame.to_html additional description for the border parameter
#60830
+14
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Feb 3, 2025
pandas/io/formats/format.py
Outdated
| the opening tag, specifying the thickness of the border. | ||
| If ``False or 0 (zero)`` is passed, the border attribute will not | ||
| be present in the `<table>`tag. | ||
mroeschke
reviewed
Feb 3, 2025
pandas/io/formats/format.py
Outdated
Comment on lines
903
to
904
| If ``False or 0 (zero)`` is passed, the border attribute will not | ||
| be present in the `<table>`tag. |
There was a problem hiding this comment.
Suggested change
| If ``False or 0 (zero)`` is passed, the border attribute will not | |
| be present in the `<table>`tag. | |
| If ``False`` or ``0`` is passed, the border attribute will not | |
| be present in the ``<table>`` tag. |
mroeschke
reviewed
Feb 3, 2025
pandas/core/frame.py
Outdated
Comment on lines
3211
to
3212
| If ``False or 0 (zero)`` is passed, the border attribute will not | ||
| be present in the `<table>` tag. |
There was a problem hiding this comment.
Suggested change
| If ``False or 0 (zero)`` is passed, the border attribute will not | |
| be present in the `<table>` tag. | |
| If ``False`` or ``0`` is passed, the border attribute will not | |
| be present in the ``<table>`` tag. |
ShashwatAgrawal20
requested review from
attack68,
rhshadrach,
MarcoGorelli and
WillAyd
as code owners
|
bro what tf just happened.. lemme just revert that |
ShashwatAgrawal20
force-pushed
the
doc_60148
branch
from
de4c096 to
a57cd44
Compare
mroeschke
approved these changes
Feb 4, 2025
|
Thanks @ShashwatAgrawal20 |
|
Even after the change, I think the docstring is not completely correct. If the user passes "0" (as a string), the border will be present. Semantically, the goal is to omit the display of the border attribute when the value is 0. The underlying problem lies in the code itself, but we should capture the behavior of the code in the docstring until the issue in the code is fixed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.