-
-
Notifications
You must be signed in to change notification settings - Fork 18.4k
DOC: Provide a public place for users to link to our documentation #55632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I personally agree that for documentation purposes, ideally we have a "path" to link to that is not linked to To be explicit, I think the classes that we are discussing here (at least the ones that were already moved in #55626) are:
There are a few others exposed in One option could be to expose them directly in Another option could also be to simply add them to the top-level namespace .. Of course, since a user never constructs those objects directly (using the class constructor), it's not very useful to have them their for other purposes than docs/typing, so that's a trade-off on whether that alone is enough for adding to the top-level namespace. |
There was early opposition to having these classes in the top namespace in #48577. I do agree with that opposition, but would be okay with them there. I am also okay with where they currently are -
|
I would say: "there is no reason for (personally, I think I have a slight preference for just putting them top-level, but I certainly understand and agree with the downsides of that) |
I'm +1 on putting them in |
We reverted the change of path, so this unblocks this issue from the release |
If the objects are just internal ones that our methods can return, what about |
I wouldn't call them "internal", in the way we typically speak about "our internals" (manager, blocks) or in the way they are internal details. Those objects are still public, the user sees those objects, calls methods on them, etc. The only thing you could consider "internal" is their So I would find |
That's reasonable. How about |
I'll add Also: Thus far, |
That works for me. Also could consider |
I'd like to start working on this if we can get past the bike shedding 😆 The following seem appropriate to me, in my order of preference:
|
I'm indifferent between |
my opinion hasn't changed, I don't really care as long as I can access them. auxiliary sounds good to me |
What's the argument again for not putting them just in Above @rhshadrach you linked to a different thread (from pandas.api.typing), but as I commented above (#55632 (comment)) for me that's mostly an argument against having submodules in Personally, I would say that any of |
@jorisvandenbossche - no opposition here, but I think we should try to have a clear rule as to what goes into
|
@jorisvandenbossche - friendly ping. |
Your rationale of what to put where sounds perfect to me |
@Dr-Irv - are you good to move forward with @jorisvandenbossche's suggestion in #55632 (comment)? That is, put these in |
Not really, and here's why. I think there should be a difference between classes/functions that users might use versus ones that are auxiliary. You previously wrote:
We currently have things like
So the current subdivisions of
So I don't think that moving the things currently in |
Thanks for the response @Dr-Irv. If there is agreement on where these things should go, I'm happy to take up the work. But I won't be actively pushing people for this agreement to happen. I'll just end by stating that I think having |
For this specific example, While Generally I would say if there is something in |
You'd use it if you were implementing your own extension array.
I'm not sure I understand this statement. Currently So I still don't think we should have any individual class or function at the |
Of course, but for this discussion that is not "typical day-to-day / interactive usage of pandas", but rather fits in the "classes and functions meant for downstream packages and extending pandas" as listed int the second bullet point in #55632 (comment) The distinction between both is always fuzzy (but in the end that's also what we can do with when deciding to put something in the top-level namespace or not) But so that's what I meant with "nothing in
Yes, you are right it isn't consistent with how we currently do things. But we are discussing here a potential new option (put things directly in Just like in the top-level The main reason I don't like using a module named "auxiliary" or "ancillary", is that IMO those don't add any value for users (they don't give meaningful categorization like eg |
So how do we decide which ones go in
That's fair, but that's an argument to have everything that is currently in |
@jorisvandenbossche and I discussed this on a call today and had a couple other ideas for these classes:
And for reference, the reason they are in
It's unclear if we chose a new location (e.g., |
Some general thoughts on a Looking at the current list of what is in
For the original motivation of this issue ("public location to link to for the docs"), we don't need all of the items on the list. For example I think |
I agree. So if we take this list
and move it to Note - the various |
Yes, that's how we currently document it. But the same is true for |
Pandas version checks
main
hereLocation of the documentation
...
Documentation problem
Currently, if users/downstream packages want to link to pandas specific docs (e.g. groupby ops and others) they have to specify the path in pandas.core.... This option becomes unavailable after deprecating pandas.core. #55626 linked to pandas.api.typing as a temporary solution for groupby ops, but we should ideally provide a place outside of typing for docs linkage.
cc @rhshadrach
Suggested fix for documentation
See above
The text was updated successfully, but these errors were encountered: