-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All Palmetto Design Tokens icons are included in build instead of only the ones that are used #593
Comments
Hey @mtblanton, I'm curious about why you added an invalid tag to this issue. |
whoops, I don't think I meant to add that! |
Oh, I think I meant for it to be "invalid behavior on your end" and not "this is an invalid issue" |
Hey @mtblanton I just wanted to confirm that this is something we have been aware of for some time, but unfortunately not come up with a viable solution that doesn't break backward compatibility with the Icon component API. The main issue is that the icon components are in a single js object that keys the icon name to its function component. This object structure is not treeshakeable as is, but I'll start working on alternatives in an upcoming sprint |
Mantine has a flag svg icons collection we may be able to take inspiration from: https://github.com/mantinedev/mantine-flagpack |
If possible, it'd be good to only import the ones we use. That may require a different setup on the Icon component though.
The text was updated successfully, but these errors were encountered: