Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

As an analytics engineer, I want to be able to configure the name of the test database in the drop_branch_schemas macro #13

Open
emekdahl-palmetto opened this issue Nov 16, 2021 · 1 comment

Comments

@emekdahl-palmetto
Copy link
Contributor

emekdahl-palmetto commented Nov 16, 2021

Subject of the issue

The test branch name is hardcoded into the macro. Make it parameterized so that others can configure it for their specific setups.

example: {%- if target.database != "TEST" -%}

Your environment

  • Version of palm
  • Operating system
  • Docker / Docker compose version
  • Relevant dependencies and versions

Steps to reproduce

Try testing with a database that isn't named "TEST"

Expected behaviour

Pass name of test database in the macro as a param

Actual behaviour

"TEST" is hardcoded in the macro

@jakeberesford-palmetto
Copy link
Collaborator

We probably want to use an env vars for this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants