Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ProxyFix 0.15 default behavior no longer to HTTP->HTTPS conversion from proxy forwarder #1543

Closed
corby opened this issue May 14, 2019 · 2 comments
Closed

ProxyFix 0.15 default behavior no longer to HTTP->HTTPS conversion from proxy forwarder #1543

corby opened this issue May 14, 2019 · 2 comments

Comments

@corby
Copy link

corby commented May 14, 2019

The ProxyFix object in 0.14 by default would pay attention to the X-Forwarded-Proto: https headers used by AWS ELB servers.
The following line was all I had to add to my flask app:
wsgi_app = ProxyFix(wsgi_app)

In 0.15 this behavior was modified and all my flask apps broke if they were behind an SSL enabled load balancer.

This is clearly a bug as it breaks backward compatibility with a minor release.
@ThiefMaster
Copy link
Member

Pass x_proto=1. But yeah, the defaults should probably be changed...

@davidism
Copy link
Member

Duplicate of #1484

@davidism davidism marked this as a duplicate of #1484 May 14, 2019
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@ThiefMaster @corby @davidism