Skip to content
This repository has been archived by the owner on Feb 22, 2024. It is now read-only.

Google provider #53

Open
NamPNQ opened this issue Jul 4, 2014 · 4 comments
Open

Google provider #53

NamPNQ opened this issue Jul 4, 2014 · 4 comments

Comments

@NamPNQ
Copy link

NamPNQ commented Jul 4, 2014

Google oauth1.0 is deprecated

@JonHMChan
Copy link

+1 - Google provider currently throws an exception with a successful API call

@vfr292
Copy link

vfr292 commented Oct 9, 2014

I'm using flask security and thought flask social would be the way to get google api log in going for my site. Is flask social using a depreciated method?

@JonHMChan
Copy link

It is - here's a quick fix I put in when on_login_failed is triggered

def on_login_failed(sender, provider, oauth_response):
    connection_values = get_connection_values_from_oauth_response(provider, oauth_response)
    if provider.name == "Google":
        name = connection_values['full_name']['givenName'] + " " + connection_values['full_name']['familyName']
        connection_values['display_name'] = name
        connection_values['full_name'] = name
    # rest of your code after this

@exhuma
Copy link

exhuma commented Mar 2, 2016

I started using flask-social about a week ago and do not see any problem with the google provider. I can successfully login.

I'd say this issue is obsolete.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

No branches or pull requests

4 participants