Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

An install.sh to make life easier #620

Open
singul4ri7y opened this issue Aug 7, 2024 · 4 comments · May be fixed by #625
Open

An install.sh to make life easier #620

singul4ri7y opened this issue Aug 7, 2024 · 4 comments · May be fixed by #625
Assignees
@singul4ri7y
Labels
enhancement New feature or request

Comments

@singul4ri7y
Copy link
Contributor

As the situation stands, we need to install Lua internals, separate version of Luarocks for that Lua and Pallene Tracer before we manually install Pallene in system. That is too much of a hassle to do by hand. A script to automate it would be nice to have.
@singul4ri7y singul4ri7y added the enhancement New feature or request label Aug 7, 2024
@singul4ri7y singul4ri7y self-assigned this Aug 7, 2024
@bjornbm
Copy link
Contributor

bjornbm commented Aug 7, 2024

Maybe consider leveraging https://github.com/oploadk/localua which already supports installing Pallene?

@hugomg
Copy link
Member

hugomg commented Aug 7, 2024

Interesting idea! I had forgotten about that script.

Do you know how that installer deals with the C bits of Pallene? Pallene needs to install C header files and shared libraries; if those aren't in a standard directory such as /usr/local then one may need to pass extra flags to the C compiler and linker...

@bjornbm
Copy link
Contributor

bjornbm commented Aug 8, 2024

See https://blog.separateconcerns.com/2022-10-10-localua-pallene.html

The Pallene compiler does not have an easy way to specify a local Lua directory and I decided against hacking it so you will have to pass CFLAGS as an environment variable for it to work.

@hugomg hugomg mentioned this issue Aug 10, 2024
Merged
@hugomg
Copy link
Member

hugomg commented Aug 10, 2024

We should also pay attention to the installation instructions for the CI, inside .github/workflows. It would be lovely if we could keep those build instructions in sync with the install.sh and the README. Perhaps by having the CI workflow call the install.sh?

@singul4ri7y singul4ri7y linked a pull request Aug 17, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@singul4ri7y singul4ri7y

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added install.sh script pallene-lang/pallene
3 participants
@bjornbm @hugomg @singul4ri7y