From c1835b9a900657a14c0e910a35d368cef6daf924 Mon Sep 17 00:00:00 2001 From: paleros <92816975+paleros@users.noreply.github.com> Date: Fri, 26 Apr 2024 11:02:33 +0200 Subject: [PATCH 1/2] Update TorpedoStore.java --- src/main/java/hu/bme/mit/spaceship/TorpedoStore.java | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java index faee2c8..c98b560 100644 --- a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java +++ b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java @@ -13,7 +13,7 @@ public class TorpedoStore { private double FAILURE_RATE = 0.0; //NOSONAR private int torpedoCount = 0; - + Random generator = new Random(); public TorpedoStore(int numberOfTorpedos){ this.torpedoCount = numberOfTorpedos; @@ -31,18 +31,18 @@ public TorpedoStore(int numberOfTorpedos){ public boolean fire(int numberOfTorpedos){ if(numberOfTorpedos < 1 || numberOfTorpedos > this.torpedoCount){ - new IllegalArgumentException("numberOfTorpedos"); + throw new IllegalArgumentException("numberOfTorpedos"); } boolean success = false; // simulate random overheating of the launcher bay which prevents firing - Random generator = new Random(); + double r = generator.nextDouble(); if (r >= FAILURE_RATE) { // successful firing - this.torpedoCount =- numberOfTorpedos; + this.torpedoCount -= numberOfTorpedos; success = true; } else { // simulated failure From e2acfd8c12847470bda8e9bedec40e5d97e35f3f Mon Sep 17 00:00:00 2001 From: paleros <92816975+paleros@users.noreply.github.com> Date: Fri, 26 Apr 2024 11:12:17 +0200 Subject: [PATCH 2/2] javitas --- src/main/java/hu/bme/mit/spaceship/TorpedoStore.java | 1 + 1 file changed, 1 insertion(+) diff --git a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java index c98b560..60380e6 100644 --- a/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java +++ b/src/main/java/hu/bme/mit/spaceship/TorpedoStore.java @@ -13,6 +13,7 @@ public class TorpedoStore { private double FAILURE_RATE = 0.0; //NOSONAR private int torpedoCount = 0; + Random generator = new Random(); public TorpedoStore(int numberOfTorpedos){